Sorry, something went wrong.
|
Could you also add a NEWS entry? |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
|
Thanks; still missing the NEWS entry, though. |
Sorry, something went wrong.
|
NEWS added :) |
Sorry, something went wrong.
|
NEWS added :) Thanks; that's some entry! :) Could you narrow it down to a couple of concise sentences that describe the actual changes only? |
Sorry, something went wrong.
|
Also, could you please add tests for each case? |
Sorry, something went wrong.
|
Also, could you please add tests for each case? Do you mean put the test cases into test_linic.py? To see if the OOB bug is fixed in commit 6203962 , I should write some code snippet calling function _PyArg_UnpackKeywordsWithVararg, compile it and ensure that it does not crash. I'm not sure how can I do this without touching the Python vm or library, As for commit 6793f38, I'm looking at test_linic.py and will have a try later. |
Sorry, something went wrong.
|
Is it still waiting for further changes? Since gh-96178 has recently been merged, we finally have a test framework for functional clinic tests, so I'd say this PR should add some tests before we are ready to land. |
Sorry, something went wrong.
|
I added some test cases and did another change in a48971d, so this PR may be necessary to be reviewed again. @erlend-aasland @isidentical @kumaraditya303 |
Sorry, something went wrong.
|
Another change in e6a4e13: |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, thanks! Kumar, Batuhan, do you have further remarks?
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
@colorfulappl, please fix the merge conflicts |
Sorry, something went wrong.
|
Thanks @colorfulappl for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
|
Sorry, @colorfulappl and @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
|
Sorry @colorfulappl and @erlend-aasland, I had trouble checking out the 3.10 backport branch. |
Sorry, something went wrong.
|
@kumaraditya303 I'm inclined to backport the functional tests for AC to 3.11 and 3.10. What do you think? We've backported tests to increase coverage in the maintained branches before; it would help backporting the AC fixes (and by the way, we should backport the AC bug fixes that we landed earlier today) |
Sorry, something went wrong.
|
GH-100368 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
|
I have backported this to 3.11 (#100368). |
Sorry, something went wrong.
|
It is too later for 3.10. |
Sorry, something went wrong.
Fix 3 bugs introduced in #18609.
Bug reason lists in each commit's commit message.
https://bugs.python.org/issue20291