← 返回首页
bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060) by tiran · Pull Request #32060 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060)#32060

Merged
tiran merged 4 commits into
python:mainfrom
tiran:tiny_sha3
Mar 26, 2022
Merged

bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060)#32060
tiran merged 4 commits into
python:mainfrom
tiran:tiny_sha3

Conversation

Copy link
Copy Markdown
Member

tiran commented Mar 22, 2022 •
edited by bedevere-bot
Loading

tiran added DO-NOT-MERGE 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Mar 22, 2022
Copy link
Copy Markdown

bedevere-bot commented Mar 22, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 62f315c3be2ac37cee8df06d03b979fcda41b219 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot added awaiting core review and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Mar 22, 2022
gpshead reviewed Mar 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

hah, that one is amazingly small. nice.

Comment thread Modules/_sha3/README.txt Outdated Show resolved Hide resolved
tiran changed the title Test with tiny_sha3 bpo-47098: Replace Keccak Code Package with tiny_sha3 Mar 23, 2022
tiran marked this pull request as ready for review March 23, 2022 09:21
Copy link
Copy Markdown
Member Author

tiran commented Mar 23, 2022

hah, that one is amazingly small. nice.

Wait until you size the binary size! It's 380kB -> 69 kB (stripped 90kB -> 25kB).

tiran added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed DO-NOT-MERGE labels Mar 23, 2022
Copy link
Copy Markdown

bedevere-bot commented Mar 23, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit e8fd0118edcd9f53686d63e417f3799620a29bdd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 23, 2022
tiran requested a review from gpshead March 25, 2022 18:58
Copy link
Copy Markdown
Member Author

tiran commented Mar 25, 2022

@gpshead please take another look

gpshead reviewed Mar 26, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-03-23-10-07-41.bpo-47098.7AN_qp.rst Outdated Show resolved Hide resolved
Comment thread Modules/_sha3/LICENSE Outdated Show resolved Hide resolved
Comment thread Modules/_sha3/sha3module.c Outdated Show resolved Hide resolved
tiran changed the title bpo-47098: Replace Keccak Code Package with tiny_sha3 bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060) Mar 26, 2022
tiran merged commit 5fd8c57 into python:main Mar 26, 2022
tiran deleted the tiny_sha3 branch March 26, 2022 20:36
This was referenced Mar 26, 2022
Closed
Closed
botovq mentioned this pull request Oct 21, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.