Sorry, something went wrong.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
| *other*. If it's impossible, ValueError is raised:: | ||
| Return the relative path to another path identified by *other*, each | ||
| element of *other* can be either a string representing a path segment, | ||
| or another path object implementing the :class:`PurePath`(or a subclass |
There was a problem hiding this comment.
Thanks. You missed the definition of class PurePath in the context, it could be changed from :class:PurePath to the class PurePath.
Sorry, something went wrong.
|
@barneygale would you be able to review this PR? |
Sorry, something went wrong.
|
I've left a comment on the #78707. I don't think relative_to() and is_relative_to() should accept multiple arguments - I'd rather we restricted this to methods that explicitly deal with path construction - PurePath() and PurePath.joinpath(). |
Sorry, something went wrong.
|
In #94469 we deprecated passing multiple positional arguments to relative_to(), so I think this patch is no longer valid. Thank you for working on it all the same! |
Sorry, something went wrong.
the docs for Path.relative_to is a bit confusing why other is a star-args, especially as no example actually passes more than one argument to relative_to
https://bugs.python.org/issue34526