← 返回首页
bpo-46659: Fix the MBCS codec alias on Windows by vstinner · Pull Request #31218 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

bpo-46659: Fix the MBCS codec alias on Windows#31218

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:mbcs_alias2
Feb 22, 2022
Merged

bpo-46659: Fix the MBCS codec alias on Windows#31218
vstinner merged 2 commits into
python:mainfrom
vstinner:mbcs_alias2

Conversation

vstinner commented Feb 8, 2022
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

@eryksun: Does this approach look good to you? It's basically restores Python 3.10 behavior. I just adjusted the test.

Comment thread Lib/test/test_codecs.py Outdated
self.assertEqual(codec.name, "mbcs")
# Check that looking up our 'default' codepage will return
# mbcs when we don't have a more specific one available
code_page = 9999

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Let's use 99999 instead, which is beyond the range of anything that Python might ever define. See code page identifiers.

eryksun commented Feb 8, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

Does this approach look good to you? It's basically restores Python 3.10 behavior. I just adjusted the test.

Yes, having a fallback for the process ANSI code page is for the best -- even though we support all of the known code pages in standard Windows locales. Thank you for clarifying the reason for its existence in the comments.

I'd prefer to also have a fallback to "oem" for the process OEM code page, but adding _winapi.GetOEMCP() is an enhancement request.

vstinner merged commit ccbe804 into python:main Feb 22, 2022
vstinner deleted the mbcs_alias2 branch February 22, 2022 21:04

Copy link
Copy Markdown
Member Author

Thanks @eryksun for your review.

My use case is to deprecate the locale.getdefaultlocale() function. Adding an alias for the OEM page code is unrelated. If you consider that it's an useful feature, you can open a separated PR. So far, nobody requested it, so maybe it's not needed. I'm not convinced that the fallbak for the ANSI code page is used by anyone.

eryksun commented Feb 23, 2022

Copy link
Copy Markdown
Contributor

I'm not convinced that the fallbak for the ANSI code page is used by anyone.

I don't know whether the ANSI fallback is used by anyone. As I said, I've never worked with supplemental/replacement custom locales. The suggestion can be shelved until someone has an issue or explicitly requests a fallback for OEM as something required for their work environment.

Copy link
Copy Markdown
Member Author

The suggestion can be shelved until someone has an issue or explicitly requests a fallback for OEM as something required for their work environment.

It sounds perfectly reasonable :-)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.