← 返回首页
bpo-46648: test_urllib2.test_issue16464() uses httpbin.org by vstinner · Pull Request #31146 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org#31146

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:urllib2_issue16464
Closed

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org#31146
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:urllib2_issue16464

Conversation

vstinner commented Feb 5, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".

https://bugs.python.org/issue46648

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org …
11b42e1
The test_issue16464() test of test_urllib2 now uses "http://httpbin.org/post" URL instead of "http://www.example.com/".
bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Feb 5, 2022

vstinner commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

cc @corona10 @ambv

tiran requested changes Feb 5, 2022
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

bedevere-bot commented Feb 5, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

tiran mentioned this pull request Feb 5, 2022
Merged
GBeauregard mentioned this pull request Feb 5, 2022
Merged
hugovk mentioned this pull request Feb 5, 2022
Merged

vstinner commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

test_urllib2 is failing on all buildbots right now because example.com is no longer reliable. Do you have a better suggestion?

I'm not aware of any pythontest.net URL supporting POST.

Either we switch to any other URL or the test should be skipped. Most buildbots are failing.

orsenthil commented Feb 6, 2022

Copy link
Copy Markdown
Member

Hi @vstinner, I am with @tiran here. If possible m we should use pythontest . I think, it supports simple post.

If blocked by external resources, we can skip the test. BTW test_urllib2net is supposed to depend on external sources. The test_urllib2 should have mocks.

vstinner closed this Feb 6, 2022
vstinner deleted the urllib2_issue16464 branch February 6, 2022 14:09

vstinner commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

I merged my PR #31161 instead (skip the test).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran tiran requested changes

Assignees

No one assigned

Labels

awaiting changes tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.