← 返回首页
bpo-46607: Add DeprecationWarning to LegacyInterpolation by hugovk · Pull Request #30927 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-46607: Add DeprecationWarning to LegacyInterpolation#30927

Merged
gpshead merged 2 commits into
python:mainfrom
hugovk:issue45173-deprecate-LegacyInterpolation
Apr 5, 2022
Merged

bpo-46607: Add DeprecationWarning to LegacyInterpolation#30927
gpshead merged 2 commits into
python:mainfrom
hugovk:issue45173-deprecate-LegacyInterpolation

Conversation

hugovk commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

LegacyInterpolation has been deprecated in docs since its introduction in Python 3.2:

class LegacyInterpolation(Interpolation): """Deprecated interpolation used in old versions of ConfigParser. Use BasicInterpolation or ExtendedInterpolation instead."""

Let's add a DeprecationWarning for a couple of releases before removal.

https://bugs.python.org/issue46607

hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 0541fd9 to 80d4f4a Compare January 26, 2022 22:00

This comment has been minimized.

Sign in to view
hugovk marked this pull request as draft January 27, 2022 09:20
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 80d4f4a to 2c616f3 Compare February 2, 2022 07:06
hugovk changed the title bpo-45173: Add DeprecationWarning to LegacyInterpolation bpo-46607: Add DeprecationWarning to LegacyInterpolation Feb 2, 2022

This comment was marked as resolved.

Sign in to view
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 2c616f3 to 850073b Compare February 2, 2022 18:45
hugovk marked this pull request as ready for review February 2, 2022 18:55
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 850073b to 2aa86b8 Compare February 3, 2022 14:28

This comment was marked as resolved.

Sign in to view
gvanrossum approved these changes Apr 2, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Looks good. Let’s do this!

gpshead merged commit 7528094 into python:main Apr 5, 2022
hugovk deleted the issue45173-deprecate-LegacyInterpolation branch April 5, 2022 16:27

tirkarthi commented Apr 12, 2022

Copy link
Copy Markdown
Member

@hugovk The PR introduces deprecation warnings in tests that need to be handled :

PYTHONWARNINGS=always ./python -Wall -m test test_configparser 0:00:00 load avg: 2.29 Run tests sequentially 0:00:00 load avg: 2.29 [1/1] test_configparser /home/karthikeyan/stuff/python/cpython/Lib/test/test_configparser.py:1031: DeprecationWarning: LegacyInterpolation has been deprecated since Python 3.2 and will be removed from the configparser module in Python 3.13. Use BasicInterpolation or ExtendedInterpolation instead. interpolation = configparser.LegacyInterpolation() == Tests result: SUCCESS == 1 test OK. Total duration: 300 ms Tests result: SUCCESS

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

@tirkarthi Thanks, will check it!

hugovk mentioned this pull request Apr 12, 2022
Merged

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

Please see #91480.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.