Sorry, something went wrong.
|
|
||
| @classmethod | ||
| def setUpClass(cls): | ||
| raise ValueError |
There was a problem hiding this comment.
This is intentional. Let's see the CI output, it should be red.
Sorry, something went wrong.
There was a problem hiding this comment.
It failed as intended: https://github.com/python/cpython/runs/4943128810?check_suite_focus=true#step:5:1483 🎉
Sorry, something went wrong.
|
@ambv: This change is about the code that you wrote if I understood correctly. |
Sorry, something went wrong.
|
I cant reproduce in 3.12.0a0 latest. |
Sorry, something went wrong.
|
I cant reproduce in 3.12.0a0 latest. I haven't tried it on 3.12, only 3.11.x Also, bit confused your command line uses .exe but output is with Linux type directories. I am on macos, since we have Python/ directory and macos does not recognise ./python executable and Python/ directory at the same time, we have to use .exe extension - just like Windows does. The use case is not clear to me. There was a problem with how tests were re-run. See #90681 (comment) for more details. |
Sorry, something went wrong.
|
@ambv: You would mind to review this regrtest fix? |
Sorry, something went wrong.
|
I can merge main later tomorrow to get this back into shape if someone wants to get this fixed :) |
Sorry, something went wrong.
|
If you want me to review, I would feel more comfortable with a new test added to test_regrtest. This code is tricky and doesn't seem to be carefully tested. |
Sorry, something went wrong.
|
Sure thing, will do! 👍 |
Sorry, something went wrong.
|
@vstinner done! I've added 8 new test cases:
|
Sorry, something went wrong.
|
Sorry, @sobolevn and @ambv, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
|
Sorry @sobolevn and @ambv, I had trouble checking out the 3.10 backport branch. |
Sorry, something went wrong.
|
3.10 is out of scope already. 3.11 I'll merge myself. |
Sorry, something went wrong.
|
Thanks everyone! 🎉 |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x RHEL7 LTO + PGO 3.x has failed when building commit 9953860. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/244/builds/4176 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Tests result: FAILURE then FAILURE == 409 tests OK. 10 slowest tests:
1 test failed: 23 tests skipped: 2 re-run tests: Total duration: 13 min 17 sec Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 770, in test_subprocess_consistent_callbacks
self.loop.run_until_complete(main())
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 762, in main
self.assertEqual(events, [
AssertionError: Lists differ: [('pi[69 chars]), 'process_exited', 'pipe_connection_lost', '[17 chars]ost'] != [('pi[69 chars]), 'pipe_connection_lost', 'pipe_connection_lo[17 chars]ted']
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script
outdir, scriptfile, python = helper.prepare(script, outdir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Tools/freeze/test/freeze.py", line 146, in prepare
copy_source_tree(srcdir, SRCDIR)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Tools/freeze/test/freeze.py", line 95, in copy_source_tree
shutil.copytree(oldroot, newroot, ignore=ignore_non_src)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/shutil.py", line 563, in copytree
return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/shutil.py", line 517, in _copytree
raise Error(errors)
shutil.Error: [(<DirEntry 'ziptest2dir'>, '/tmp/test_python_ata8db4y/tmpza4jrie3/cpython/build/test_python_41350æ/test_python_worker_49510æ/tempcwd/ziptest2dir', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/build/test_python_41350æ/test_python_worker_49510æ/tempcwd/ziptest2dir'"), (<DirEntry 'tempcwd'>, '/tmp/test_python_ata8db4y/tmpza4jrie3/cpython/build/test_python_41350æ/test_python_worker_49510æ/tempcwd', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/build/test_python_41350æ/test_python_worker_49510æ/tempcwd'")]
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 770, in test_subprocess_consistent_callbacks
self.loop.run_until_complete(main())
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 762, in main
self.assertEqual(events, [
AssertionError: Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']
|
Sorry, something went wrong.
|
See #103170 for this buildbot failure. |
Sorry, something went wrong.
|
GH-103342 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Problem
There were two problems:
I've fixed both problems.
Local testing
setUpModule
setUpClass
https://gist.github.com/sobolevn/adcaf0d470226b8644f70ef81178e028
setUp
https://gist.github.com/sobolevn/acf04e0f7ea785e1fa4c45a94f545743
https://bugs.python.org/issue46523