← 返回首页
Refactor sanitizer skip tests into test.support by pablogsal · Pull Request #30889 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Refactor sanitizer skip tests into test.support#30889

Merged
pablogsal merged 3 commits into
python:mainfrom
pablogsal:asan
Jan 25, 2022
Merged

Refactor sanitizer skip tests into test.support#30889
pablogsal merged 3 commits into
python:mainfrom
pablogsal:asan

Conversation

pablogsal commented Jan 25, 2022

Copy link
Copy Markdown
Member

No description provided.

erlend-aasland approved these changes Jan 25, 2022
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Nice addition. LGTM, with a single remark.

Comment thread Lib/test/support/__init__.py Outdated
'--with-memory-sanitizer' in _config_args
)
address_sanitizer = (
'-fsanitize=address' in _cflags

erlend-aasland Jan 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Also check '--with-memory-sanitizer' in _config_args

erlend-aasland commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

I'd add a NEWS entry and possibly document it in the test support section.

erlend-aasland reviewed Jan 25, 2022
View reviewed changes
Comment thread Lib/test/support/__init__.py Outdated
"run_with_tz", "PGO", "missing_compiler_executable",
"ALWAYS_EQ", "NEVER_EQ", "LARGEST", "SMALLEST",
"LOOPBACK_TIMEOUT", "INTERNET_TIMEOUT", "SHORT_TIMEOUT", "LONG_TIMEOUT",
"skip_if_sanitizer",

erlend-aasland Jan 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Nit: this probably belongs in the unittest section between line 34 and 44.

pablogsal commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

I'd add a NEWS entry and possibly document it in the test support section.

The news section is for user visible changes, this is an internal change.

pablogsal merged commit b1cb843 into python:main Jan 25, 2022
pablogsal deleted the asan branch January 25, 2022 22:01
vstinner mentioned this pull request Mar 1, 2022
Merged
vstinner added a commit that referenced this pull request Mar 2, 2022
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G… …
9326445
…H-31634) * Refactor sanitiser skip tests into test.support (GH-30889) * Refactor sanitizer skip tests into test.support (cherry picked from commit b1cb843) * Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897) (cherry picked from commit a275053) * bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) Skip tests on ASAN and/or MSAN builds: * multiprocessing tests * test___all__ * test_concurrent_futures * test_decimal * test_peg_generator * test_tools (cherry picked from commit 9204bb7) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
vstinner mentioned this pull request Mar 2, 2022
Merged
vstinner added a commit that referenced this pull request Mar 2, 2022
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G… …
359bc39
…H-31634) (GH-31644) * Refactor sanitiser skip tests into test.support (GH-30889) * Refactor sanitizer skip tests into test.support (cherry picked from commit b1cb843) * Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897) (cherry picked from commit a275053) * bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) Skip tests on ASAN and/or MSAN builds: * multiprocessing tests * test___all__ * test_concurrent_futures * test_decimal * test_peg_generator * test_tools (cherry picked from commit 9204bb7) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> (cherry picked from commit 9326445)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632… …
c36f6d7
…) (pythonGH-31634) (pythonGH-31644) * Refactor sanitiser skip tests into test.support (pythonGH-30889) * Refactor sanitizer skip tests into test.support (cherry picked from commit b1cb843) * Add skips to crashing tests under sanitizers instead of manually skipping them (pythonGH-30897) (cherry picked from commit a275053) * bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632) Skip tests on ASAN and/or MSAN builds: * multiprocessing tests * test___all__ * test_concurrent_futures * test_decimal * test_peg_generator * test_tools (cherry picked from commit 9204bb7) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> (cherry picked from commit 9326445)
gpshead mentioned this pull request Jun 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.