← 返回首页
bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) by tiran · Pull Request #30507 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507)#30507

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-46315-wasi
Jan 13, 2022
Merged

bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507)#30507
tiran merged 1 commit into
python:mainfrom
tiran:bpo-46315-wasi

Conversation

tiran commented Jan 9, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • add check for HAVE_CLOCK
  • use HAVE_PTHREAD_H to guard include of pthread.h
  • guard getpid() with HAVE_GETPID
  • guard clock() with HAVE_CLOCK
  • add checks for HAVE_UMASK and HAVE_CHMOD
  • guard include of setjmp.h
  • use signal emulation on WASI

https://bugs.python.org/issue46315

tiran requested review from a team and rhettinger as code owners January 9, 2022 18:46
erlend-aasland approved these changes Jan 9, 2022
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm

bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility …
859bbbc
* add check for HAVE_CLOCK * use HAVE_PTHREAD_H to guard include of pthread.h * guard getpid() with HAVE_GETPID * guard clock() with HAVE_CLOCK * add checks for HAVE_UMASK and HAVE_CHMOD * guard include of setjmp.h * use signal emulation on WASI
tiran changed the title bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) Jan 13, 2022
tiran merged commit a6ca8ee into python:main Jan 13, 2022
tiran deleted the bpo-46315-wasi branch January 13, 2022 08:46
tiran mentioned this pull request Oct 4, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.