← 返回首页
bpo-23952: Document cgi module's maxlen variable by hugovk · Pull Request #30338 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-23952: Document cgi module's maxlen variable#30338

Merged
ethanfurman merged 3 commits into
python:mainfrom
hugovk:23952-cgi-document-maxlen
Feb 6, 2022
Merged

bpo-23952: Document cgi module's maxlen variable#30338
ethanfurman merged 3 commits into
python:mainfrom
hugovk:23952-cgi-document-maxlen

Conversation

hugovk commented Jan 2, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Using the text suggested in https://bugs.python.org/issue23952.

I think this documentation-only change can skip a NEWS file.

https://bugs.python.org/issue23952

hugovk requested a review from ethanfurman as a code owner January 2, 2022 20:12
rhettinger requested changes Jan 2, 2022
View reviewed changes

rhettinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This is a good start. Please also update the main docs at Docs/library/cgi.rst.

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger added skip news docs Documentation in the Doc dir labels Jan 2, 2022

hugovk commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

This is a good start. Please also update the main docs at Docs/library/cgi.rst.

Updated!

I have made the requested changes; please review again.

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

ethanfurman requested changes Jan 2, 2022
View reviewed changes
Comment thread Lib/cgi.py Outdated Show resolved Hide resolved

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hugovk commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-bot commented Jan 2, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger, @ethanfurman: please review the changes made to this pull request.

github-actions Bot commented Feb 2, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 2, 2022
ethanfurman added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed stale Stale PR or inactive for long period of time. labels Feb 5, 2022

bedevere-bot commented Feb 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ethanfurman for commit 90442ca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2022

hugovk commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

test_issue16464 (test.test_urllib2.MiscTests) ... ERROR failed with urllib.error.HTTPError: HTTP Error 404: Not Found.

Details
test_issue16464 (test.test_urllib2.MiscTests) ... ERROR ====================================================================== ERROR: test_issue16464 (test.test_urllib2.MiscTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/contextlib.py", line 155, in __exit__ self.gen.throw(typ, value, traceback) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/test/support/socket_helper.py", line 245, in transient_internet yield ^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/test/test_urllib2.py", line 1803, in test_issue16464 opener.open(request, "1234567890".encode("us-ascii")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 525, in open response = meth(req, response) ^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 634, in http_response response = self.parent.error( ^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 563, in error return self._call_chain(*args) ^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 496, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 643, in http_error_default raise HTTPError(req.full_url, code, msg, hdrs, fp) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ urllib.error.HTTPError: HTTP Error 404: Not Found

https://buildbot.python.org/all/#/builders/217/builds/431/steps/5/logs/stdio

Likely unrelated to this docs change, so rescheduling.

hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2022

bedevere-bot commented Feb 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 90442ca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2022

hugovk commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Same thing. The test_issue16464 failure is unrelated; https://bugs.python.org/issue46648 / #31146 / #31148.

ethanfurman merged commit 6c4e44e into python:main Feb 6, 2022
hugovk deleted the 23952-cgi-document-maxlen branch February 6, 2022 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ethanfurman ethanfurman approved these changes
rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.