← 返回首页
bpo-44136: pathlib: merge `_Flavour.make_uri()` into `PurePath.as_uri()` by barneygale · Pull Request #30320 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-44136: pathlib: merge _Flavour.make_uri() into PurePath.as_uri()#30320

Closed
barneygale wants to merge 2 commits into
python:mainfrom
barneygale:bpo-44136-merge-as-uri
Closed

bpo-44136: pathlib: merge _Flavour.make_uri() into PurePath.as_uri()#30320
barneygale wants to merge 2 commits into
python:mainfrom
barneygale:bpo-44136-merge-as-uri

Conversation

barneygale commented Jan 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Removes a bit of indirection.

https://bugs.python.org/issue44136

github-actions Bot commented Feb 1, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 1, 2022
barneygale mentioned this pull request Feb 21, 2022
Closed
brettcannon self-requested a review February 22, 2022 23:33
brettcannon reopened this Feb 25, 2022
MaxwellDupre approved these changes Feb 26, 2022
View reviewed changes

MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Looks ok to me.

brettcannon commented Mar 4, 2022

Copy link
Copy Markdown
Member

So why do this? I noticed as_uri() wasn't moved under PurePosixPath, so why the half move? And what's going to be gained by doing this? I know the issue mentioned potential future benefits, but I would rather make the actual change with the future benefit rather than in hopes of the benefit materializing.

Basically the code doesn't read any simpler/cleaner, and with PurePosixPath not changed I'm not finding it more readable, so it feels a bit too much like code churn without understanding the deeper motivation.

barneygale commented Mar 4, 2022

Copy link
Copy Markdown
Contributor Author

Fair enough. I'll bundle this into a larger PR that has a more tangible benefit.

barneygale closed this Mar 4, 2022
barneygale mentioned this pull request Mar 4, 2022
Closed
barneygale mannequin mentioned this pull request Jun 21, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon Awaiting requested review from brettcannon
1 more reviewer
MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.