← 返回首页
bpo-45723: Normalise configure user communication (GH-30024) by erlend-aasland · Pull Request #30024 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-45723: Normalise configure user communication (GH-30024)#30024

Merged
tiran merged 1 commit into
python:mainfrom
erlend-aasland:ac-msg
Dec 10, 2021
Merged

bpo-45723: Normalise configure user communication (GH-30024)#30024
tiran merged 1 commit into
python:mainfrom
erlend-aasland:ac-msg

Conversation

erlend-aasland commented Dec 10, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Normalise configure user communication; always use AC_MSG_* macros.

https://bugs.python.org/issue45723

erlend-aasland requested a review from tiran December 10, 2021 10:59
erlend-aasland changed the title bpo-45723: Use AC_MSG_* for configure user communication bpo-45723: Normalise configure user communication Dec 10, 2021

tiran commented Dec 10, 2021

Copy link
Copy Markdown
Member

Thanks!

tiran changed the title bpo-45723: Normalise configure user communication bpo-45723: Normalise configure user communication (GH-30024) Dec 10, 2021
tiran merged commit 74b23c9 into python:main Dec 10, 2021
erlend-aasland deleted the ac-msg branch December 10, 2021 11:29
erlend-aasland commented Dec 10, 2021
View reviewed changes
Comment thread configure.ac
if test -z "$ANDROID_API_LEVEL"; then
echo 'Fatal: you must define __ANDROID_API__'
exit 1
AC_MSG_ERROR([Fatal: you must define __ANDROID_API__])

erlend-aasland Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Argh, I forgot to remove the "Fatal: " prefix. I'll add it to a future autoconf PR.

tiran mentioned this pull request Apr 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran tiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.