← 返回首页
bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) by erlend-aasland · Pull Request #29466 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466)#29466

Merged
tiran merged 8 commits into
python:mainfrom
erlend-aasland:ac-cc-flags
Nov 8, 2021
Merged

bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466)#29466
tiran merged 8 commits into
python:mainfrom
erlend-aasland:ac-cc-flags

Conversation

erlend-aasland commented Nov 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add PY_CHECK_CC_WARNING helper
  • Normalise variable name: ac_cv_[enable|disable]_[flag_name]_warning; for example ac_cv_disable_unused_result_warning
  • Use AS_IF to check results and add flags

No new cache vars added, so there is no speedups; only simplified ac code.

Bonus: fixed a misspelling bug (see ac_cv_enable_enable_strict_prototypes_warning)

https://bugs.python.org/issue45723

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

cc. @tiran

tiran reviewed Nov 8, 2021
View reviewed changes
Comment thread configure.ac Outdated Show resolved Hide resolved
erlend-aasland marked this pull request as ready for review November 8, 2021 10:47
erlend-aasland requested a review from tiran November 8, 2021 10:47
tiran reviewed Nov 8, 2021
View reviewed changes
Comment thread configure.ac Outdated Show resolved Hide resolved
Comment thread configure.ac Outdated Show resolved Hide resolved
Comment thread configure.ac Outdated Show resolved Hide resolved
Address review …
304f780
- Use AS_VAR_IF() a couple of more times - Use CFLAGS iso. CC when overriding compiler flags
erlend-aasland requested a review from tiran November 8, 2021 12:03
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021

bedevere-bot commented Nov 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 304f780 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

Do you want a NEWS item for this, @tiran?

tiran approved these changes Nov 8, 2021
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, thanks!

erlend-aasland commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!

tiran changed the title bpo-45723: Add macro for disabling/enabling CC warnings bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) Nov 8, 2021
tiran merged commit 9bd0cf5 into python:main Nov 8, 2021
erlend-aasland deleted the ac-cc-flags branch November 8, 2021 17:59
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45723: Add macro for disabling/enabling CC warnings (pythonGH-29466) …
778b147
Co-authored-by: Christian Heimes <christian@python.org>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
bpo-45723: Add macro for disabling/enabling CC warnings (pythonGH-29466) …
29514b3
Co-authored-by: Christian Heimes <christian@python.org>
tiran mentioned this pull request Apr 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran tiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.