← 返回首页
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value… by iritkatriel · Pull Request #29404 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value…#29404

Merged
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:bpo-45711-type_val_tb
Nov 10, 2021
Merged

bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value…#29404
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:bpo-45711-type_val_tb

Conversation

iritkatriel commented Nov 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

… to NULL

This PR tidies up exception handling in Future/Task._make_cancelled_error to make it clearer what's happening and pave the way for a refactor of how the interpreter represents exceptions.

https://bugs.python.org/issue45711

iritkatriel requested a review from asvetlov as a code owner November 4, 2021 13:24
iritkatriel commented Nov 7, 2021
View reviewed changes
Comment thread Modules/_asynciomodule.c
/* Transfer ownership of exc_value from exc_state to exc since we are
done with it. */
PyException_SetContext(exc, exc_state->exc_value);
exc_state->exc_value = NULL;

iritkatriel Nov 7, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Note that PyErr_Occurred checks whether the type is NULL, not the value. So setting just the value to NULL here doesn't follow the interpreter's semantics for the triplet.

gvanrossum reviewed Nov 7, 2021
View reviewed changes
Comment thread Modules/_asynciomodule.c Outdated Show resolved Hide resolved
asvetlov approved these changes Nov 10, 2021
View reviewed changes

asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, the PR is correct.

iritkatriel merged commit 05fbd60 into python:main Nov 10, 2021
iritkatriel deleted the bpo-45711-type_val_tb branch November 10, 2021 19:20
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value… …
d6e9dc6
… to NULL (pythonGH-29404)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value… …
6158fb0
… to NULL (pythonGH-29404)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asvetlov asvetlov approved these changes
gvanrossum gvanrossum approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
cjerdonek Awaiting requested review from cjerdonek
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.