← 返回首页
bpo-31040: Add warning note about mimetypes.add_type ext argument format by OddBloke · Pull Request #2871 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-31040: Add warning note about mimetypes.add_type ext argument format#2871

Closed
OddBloke wants to merge 2 commits into
python:mainfrom
OddBloke:docs-for-31040
Closed

bpo-31040: Add warning note about mimetypes.add_type ext argument format#2871
OddBloke wants to merge 2 commits into
python:mainfrom
OddBloke:docs-for-31040

Conversation

OddBloke commented Jul 25, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This addresses the documentation of the issue described in bpo-31040,
but not the underlying issue.

https://bugs.python.org/issue31040

Add warning note about mimetypes.add_type ext argument format …
e6571ca
This addresses the documentation of the issue described in bpo-31040, but not the underlying issue.

the-knights-who-say-ni commented Jul 25, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

OddBloke changed the title Add warning note about mimetypes.add_type ext argument format bpo-31040: Add warning note about mimetypes.add_type ext argument format Jul 25, 2017

OddBloke commented Jul 25, 2017

Copy link
Copy Markdown
Contributor Author

(I signed the CLA just before submitting this PR, so that should be cleared up fairly soon.)

matrixise added the docs Documentation in the Doc dir label May 15, 2019
JulienPalard requested changes Sep 13, 2019
View reviewed changes
Comment thread Doc/library/mimetypes.rst

.. note::

The *ext* argument should start with a dot ("``.``") for the

JulienPalard Sep 13, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please also explicitly tell it can be empty, see b.p.o.

bedevere-bot commented Sep 13, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

csabella commented Jan 12, 2020

Copy link
Copy Markdown
Contributor

@OddBloke, please address the code review comments from @JulienPalard. Thanks!

csabella commented May 28, 2020

Copy link
Copy Markdown
Contributor

@OddBloke ping

github-actions Bot commented Feb 20, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
JelleZijlstra requested a review from a team as a code owner March 31, 2022 03:49

JelleZijlstra commented May 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Closing as it's been almost three years since the requested change.

OddBloke mannequin mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JulienPalard JulienPalard requested changes

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Footer

© 2026 GitHub, Inc.