← 返回首页
bpo-5846: Do not use obsolete unittest functions. by serhiy-storchaka · Pull Request #28303 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-5846: Do not use obsolete unittest functions.#28303

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:unittest-makesuite
Sep 13, 2021
Merged

bpo-5846: Do not use obsolete unittest functions.#28303
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:unittest-makesuite

Conversation

serhiy-storchaka commented Sep 13, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.

https://bugs.python.org/issue5846

erlend-aasland requested changes Sep 13, 2021
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please use defaultTestLoader instead of creating a new instance whenever possible.

bpo-5846: Do not use obsolete unittest functions. …
af2f55f
Get rid of use of makeSuite() and findTestCases(). Also make test_math and test_threading_local discoverable.
serhiy-storchaka merged commit 851811f into python:main Sep 13, 2021
serhiy-storchaka deleted the unittest-makesuite branch September 13, 2021 07:49
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Sep 13, 2021
Merge branch 'main' into fix-issue-5846 …
db40a08
Sync with main bco. python#28303
voidspace mentioned this pull request May 24, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
encukou Awaiting requested review from encukou
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.