← 返回首页
bpo-42238: Doc CI: Disable suspicious checks. by JulienPalard · Pull Request #26575 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

bpo-42238: Doc CI: Disable suspicious checks.#26575

Merged
JulienPalard merged 1 commit into
python:mainfrom
JulienPalard:mdk/drop-suspicious
Jun 8, 2021
Merged

bpo-42238: Doc CI: Disable suspicious checks.#26575
JulienPalard merged 1 commit into
python:mainfrom
JulienPalard:mdk/drop-suspicious

Conversation

JulienPalard commented Jun 7, 2021
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

They are slow and raise too many false positive, I'm in the slow
process to try to change this.

I've removed it from PEP 101 too to avoid the burden for RMs.

I've setup a cron to follow this closely / to avoid to forgot to monitor this closely.

https://bugs.python.org/issue42238

They are slow and raise too many false positive, I'm in the slow process to try to change this.

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

Maybe you can document this unknown command in the devguide? For example, near:
https://devguide.python.org/documenting/#gotchas

JulienPalard merged commit 227a093 into python:main Jun 8, 2021
JulienPalard deleted the mdk/drop-suspicious branch June 8, 2021 07:23

Copy link
Copy Markdown
Member Author

For the moment my biggest issue is: people are autonomously and quietly fixing what's reported by make suspicious, so I don't have a list of true positives to work on.

So my current idea is to let people people commit errors¹, fix them myself (I've setup a build bot to monitor this closely) to document true positives and try to implement them in make check (or in Sphinx).

1: It is not expected to happen often, and have the nice side effet of not bothering people with false positives: 9 out of 12 errors reported by make suspicious are false positives.

Copy link
Copy Markdown

GH-98221 is a backport of this pull request to the 3.10 branch.

JulienPalard added a commit that referenced this pull request Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.