← 返回首页
Minor edits to the Descriptor HowTo Guide by geryogam · Pull Request #24901 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Minor edits to the Descriptor HowTo Guide#24901

Merged
rhettinger merged 25 commits into
python:mainfrom
geryogam:patch-14
Oct 9, 2022
Merged

Minor edits to the Descriptor HowTo Guide#24901
rhettinger merged 25 commits into
python:mainfrom
geryogam:patch-14

Conversation

geryogam commented Mar 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR provides the following changes to the Descriptor HowTo Guide:

  • fix a typo;
  • fix a Sphinx tag preventing syntax highlighting;
  • fix a bug in ClassMethod;
  • reuse an existing cls name in Object;
  • allow keyword arguments in Type.__new__ and Object.__new__;
  • allow attribute lookup from a class in Member.__get__;
  • use two more super() in Object and Type for consistency.

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 17, 2021
geryogam changed the title Fix a bug in the ClassMethod Python equivalent of the Descriptor HowTo Guide Fix a few bugs in the Python equivalent code of the Descriptor HowTo Guide Mar 19, 2021
geryogam changed the title Fix a few bugs in the Python equivalent code of the Descriptor HowTo Guide Fix a few bugs in the Python equivalents of the Descriptor HowTo Guide Mar 19, 2021
geryogam changed the title Fix a few bugs in the Python equivalents of the Descriptor HowTo Guide Fix the Python equivalents of the Descriptor HowTo Guide Mar 31, 2021

github-actions Bot commented Jun 5, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 5, 2021

merwok commented Feb 11, 2022

Copy link
Copy Markdown
Member

Can you open a ticket (with Raymond Hettinger in nosy) to discuss the problems you have identified here?

geryogam commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

@merwok Thanks for the suggestion, that’s what I intended to do. The rest of the PR is completed but I still have to finish the last section on __slots__ (I completed my tests on it last year but I did not take the extra days necessary to update this PR). I will try to find a weekend shortly to do it.

rhettinger reviewed May 10, 2022
View reviewed changes
Comment thread Doc/howto/descriptor.rst Show resolved Hide resolved
rhettinger requested changes May 10, 2022
View reviewed changes
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
5 hidden conversations Load more…
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Show resolved Hide resolved
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

44 hidden items Load more…
geryogam requested a review from rhettinger October 4, 2022 21:37

merwok commented Oct 7, 2022

Copy link
Copy Markdown
Member

Please open a ticket to track this properly.

geryogam mentioned this pull request Oct 7, 2022
Closed

geryogam commented Oct 7, 2022

Copy link
Copy Markdown
Contributor Author

Please open a ticket to track this properly.

Done: #98038

rhettinger requested changes Oct 7, 2022
View reviewed changes
Comment thread Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
rhettinger changed the title Improve the Descriptor HowTo Guide Minor edits to the Descriptor HowTo Guide Oct 7, 2022
rhettinger merged commit 2d2e01a into python:main Oct 9, 2022

miss-islington commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented Oct 9, 2022

Copy link
Copy Markdown

GH-98112 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2022
Minor edits to the Descriptor HowTo Guide (pythonGH-24901) …
3699a37
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
rhettinger added the needs backport to 3.10 only security fixes label Oct 9, 2022

miss-islington commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Oct 9, 2022

Copy link
Copy Markdown

GH-98114 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2022
Minor edits to the Descriptor HowTo Guide (pythonGH-24901) …
c05b145
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Oct 9, 2022
Minor edits to the Descriptor HowTo Guide (GH-24901) …
6554598
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
rhettinger pushed a commit that referenced this pull request Oct 9, 2022
[3.10] Minor edits to the Descriptor HowTo Guide (GH-24901) (GH-98114)
820ef62
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
Merge branch 'main' into typewatch …
71d48c1
* main: Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102) pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009) pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
Merge branch 'main' into urllibnonet …
132c32e
* main: (5519 commits) Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102) pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009) pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012) pythongh-68686: Retire eptag ptag scripts (python#98064) pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079) pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914) pythongh-97822: Fix http.server documentation reference to test() function (python#98027) pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055) pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024) pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) ...

geryogam commented Oct 9, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review.

geryogam deleted the patch-14 branch October 10, 2022 21:53
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Minor edits to the Descriptor HowTo Guide (pythonGH-24901) …
cef2db9
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
Minor edits to the Descriptor HowTo Guide (GH-24901) …
7460cf4
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

merwok merwok left review comments
rhettinger rhettinger requested changes

Assignees

rhettinger

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.