← 返回首页
gh-87526: Remove dead initialization from parse_abbr function by alexhenrie · Pull Request #24700 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-87526: Remove dead initialization from parse_abbr function#24700

Merged
vstinner merged 1 commit into
python:mainfrom
alexhenrie:parse_abbr
May 12, 2023
Merged

gh-87526: Remove dead initialization from parse_abbr function#24700
vstinner merged 1 commit into
python:mainfrom
alexhenrie:parse_abbr

Conversation

alexhenrie commented Mar 2, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 2, 2021
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 4, 2022

furkanonder commented May 9, 2023

Copy link
Copy Markdown
Contributor

LGTM. @alexhenrie Can you add the news entry?

furkanonder commented May 9, 2023

Copy link
Copy Markdown
Contributor

CC: @vstinner

arhadthedev commented May 9, 2023

Copy link
Copy Markdown
Member

Can you add the news entry?

This change is invisible to users and irrelevant for contributors so adding skip news .

arhadthedev changed the title bpo-43360: Remove dead initialization from parse_abbr function gh-87526: Remove dead initialization from parse_abbr function May 9, 2023
vstinner reviewed May 9, 2023
View reviewed changes
Comment thread Modules/_zoneinfo.c Outdated
{
const char *ptr = p;
char buff = *ptr;
char buff;

vstinner May 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I suggest to move the variable declaration closer to where it's used: inside the if block at least.

alexhenrie May 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Done

vstinner merged commit 3c2992e into python:main May 12, 2023

vstinner commented May 12, 2023

Copy link
Copy Markdown
Member

Merged, thanks.

alexhenrie mannequin mentioned this pull request Apr 5, 2023
Closed
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
Merge branch 'main' into supermon …
8efd7c6
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
furkanonder furkanonder approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.