← 返回首页
bpo-1635741: Adapt _multibytecodec to multi-phase initialization by erlend-aasland · Pull Request #24095 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: Adapt _multibytecodec to multi-phase initialization#24095

Merged
vstinner merged 17 commits into
python:masterfrom
erlend-aasland:multibytecodec-module-state
Jan 4, 2021
Merged

bpo-1635741: Adapt _multibytecodec to multi-phase initialization#24095
vstinner merged 17 commits into
python:masterfrom
erlend-aasland:multibytecodec-module-state

Conversation

erlend-aasland commented Jan 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Establish module state
  • Convert types to heap types and add them to module state
  • Add multi-phase init support

https://bugs.python.org/issue1635741

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
Contributor Author

@corona10 or @shihai1991, would one of you mind reviewing this PR?

shihai1991 reviewed Jan 4, 2021
View reviewed changes

shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM. just nitpicks in here. And no refleaks when I run ./python -m test test_multibytecodec -R 3:3 -vv.

Comment thread Misc/NEWS.d/next/Library/2021-01-04-15-05-40.bpo-1635741.EOCfZY.rst Outdated Show resolved Hide resolved
Comment thread Modules/cjkcodecs/multibytecodec.c Outdated Show resolved Hide resolved
vstinner reviewed Jan 4, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2021-01-04-15-05-40.bpo-1635741.EOCfZY.rst Outdated Show resolved Hide resolved
Comment thread Modules/cjkcodecs/multibytecodec.c Outdated Show resolved Hide resolved
Comment thread Modules/cjkcodecs/multibytecodec.c Outdated Show resolved Hide resolved
Comment thread Modules/cjkcodecs/multibytecodec.c Outdated Show resolved Hide resolved
Comment thread Modules/cjkcodecs/multibytecodec.c Show resolved Hide resolved
erlend-aasland force-pushed the multibytecodec-module-state branch from 90deaf4 to e8b3021 Compare January 4, 2021 20:55

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for your review, @vstinner. PTAL.

vstinner reviewed Jan 4, 2021
View reviewed changes
Comment thread Modules/cjkcodecs/multibytecodec.c Outdated Show resolved Hide resolved
Erlend Egeberg Aasland and others added 2 commits January 4, 2021 22:08
Rename __methods to _multibytecodec_methods for consistency …
18c1829
Co-authored-by: Victor Stinner <vstinner@python.org>
Fix rename
bf3da94
vstinner merged commit 0b858cd into python:master Jan 4, 2021

vstinner commented Jan 4, 2021

Copy link
Copy Markdown
Member

Merged, thanks.

erlend-aasland deleted the multibytecodec-module-state branch January 4, 2021 21:37

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
Contributor Author

Merged, thanks.

Great, thanks for a thorough review!

neonene mentioned this pull request Jan 8, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-1635741: Convert _multibytecodec to multi-phase init (pythonGH-24095 …
42e5f6b
) Convert the _multibytecodec extension module (CJK codecs) to multi-phase initialization (PEP 489).
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 Awaiting requested review from corona10
encukou Awaiting requested review from encukou
shihai1991 Awaiting requested review from shihai1991
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.