← 返回首页
bpo-1635741: In pickle module, inject module state from class methods by koubaa · Pull Request #23304 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: In pickle module, inject module state from class methods#23304

Closed
koubaa wants to merge 2 commits into
python:mainfrom
koubaa:bpo-1635741-picklestate-inject
Closed

bpo-1635741: In pickle module, inject module state from class methods#23304
koubaa wants to merge 2 commits into
python:mainfrom
koubaa:bpo-1635741-picklestate-inject

Conversation

koubaa commented Nov 15, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This PR prepares for changing to heap types.
When switching to heap types, the clinic can be used to get the module state.

https://bugs.python.org/issue1635741

koubaa changed the title bpo-1635741 - inject module state from class methods bpo-1635741: In pickle module, inject module state from class methods Nov 15, 2020

koubaa commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 please review

koubaa commented Nov 15, 2020
View reviewed changes
Comment thread Modules/_pickle.c Outdated

koubaa Nov 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

PickleState is not used here, but is added as an argument to avoid complicating the macro/switch case in

static PyObject * load(UnpicklerObject *self, PickleState *st)

tiran commented Nov 18, 2020

Copy link
Copy Markdown
Member

Most modules are using state for the state variable. Could you please replace st with state so we have a consistent naming scheme across the code base?

koubaa commented Nov 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Most modules are using state for the state variable. Could you please replace st with state so we have a consistent naming scheme across the code base?

@tiran I did that in my initial draft here. The reason I didn't do it here is because there are local variables named state in some functions (see for example line 3949 in save_reduce. Do you have a suggestion on what to change those names to? I don't understand exactly what those variables represent

github-actions Bot commented Dec 21, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 21, 2020
shihai1991 reviewed Dec 21, 2020
View reviewed changes

shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The reason I didn't do it here is because there are local variables named state in some functions (see for example line 3949 in save_reduce.

the state would be more exact. If there have other arguments have own this name, keep st unchanged is not a big probleam.

Comment thread Modules/_pickle.c Outdated Show resolved Hide resolved
Comment thread Modules/_pickle.c Outdated Show resolved Hide resolved
vstinner reviewed Jan 20, 2021
View reviewed changes
Comment thread Modules/_pickle.c Outdated Show resolved Hide resolved
Comment thread Modules/_pickle.c Outdated Show resolved Hide resolved
Comment thread Modules/_pickle.c Outdated Show resolved Hide resolved
koubaa added 2 commits March 4, 2021 20:49
get module state from class methods …
ee54eb3
when switching to heap types, the clinic can be used to get the module state therte
address PR comments
eea5c35
koubaa force-pushed the bpo-1635741-picklestate-inject branch from d7cad26 to eea5c35 Compare March 7, 2021 17:21

koubaa commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

@shihai1991 @vstinner I addressed these comments

shihai1991 approved these changes Mar 8, 2021
View reviewed changes

shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This PR is huge :) . About adding parenthesis, I will update it when those code have relation with the bpo.

iritkatriel commented Apr 11, 2022

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741 is closed. What is the status of this PR?

vstinner commented Apr 19, 2022

Copy link
Copy Markdown
Member

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.

FYI, PEP 687 was accepted.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed

encukou commented Mar 28, 2024

Copy link
Copy Markdown
Member

Pickle module state was isolated in #102982. koubaa is listed as co-author, so I hope some of this work made it in at the end.

encukou closed this Mar 28, 2024

erlend-aasland commented Mar 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pickle module state was isolated in #102982. koubaa is listed as co-author, so I hope some of this work made it in at the end.

It did; PR #102982 was based off of Mohamed's work in #23188 (IIRC, I cherry-picked the commits from this that PR onto my new branch). See also #23188 (comment).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
shihai1991 shihai1991 approved these changes
corona10 Awaiting requested review from corona10

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Footer

© 2026 GitHub, Inc.