← 返回首页
gh-103092: Prep curses module for multi-phase init by koubaa · Pull Request #23091 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-103092: Prep curses module for multi-phase init#23091

Closed
koubaa wants to merge 3 commits into
python:mainfrom
koubaa:bpo-1635741-curses-prep
Closed

gh-103092: Prep curses module for multi-phase init#23091
koubaa wants to merge 3 commits into
python:mainfrom
koubaa:bpo-1635741-curses-prep

Conversation

koubaa commented Nov 2, 2020 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

shihai1991 reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated Show resolved Hide resolved
shihai1991 reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated Show resolved Hide resolved
shihai1991 reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated Show resolved Hide resolved

shihai1991 commented Nov 2, 2020

Copy link
Copy Markdown
Member

cc @vstinner @corona10

koubaa marked this pull request as draft November 3, 2020 00:31
koubaa marked this pull request as ready for review November 4, 2020 02:37

koubaa commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 please review

vstinner reviewed Nov 4, 2020
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated Show resolved Hide resolved

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
koubaa force-pushed the bpo-1635741-curses-prep branch from c96930b to 0dc705b Compare February 28, 2021 18:31

koubaa commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner would you please review?

vstinner reviewed Mar 11, 2021
View reviewed changes
Comment thread Modules/_cursesmodule.c
} \
if (PyDict_SetItemString(d, string, o) < 0) { \
Py_DECREF(o); \
goto error; \

vstinner Mar 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

"return NULL;" is enough: you should remove the error label. An error label is used when you need to clean up things, it's not the case here. Same remark at the bottom of the file.

Comment thread Modules/_cursesmodule.c
return NULL;
}

static void *PyCurses_API[PyCurses_API_pointers];

vstinner Mar 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

There are warnings on the PR, like ‘PyCurses_API’ defined but not used [-Wunused-variable].

iritkatriel commented Apr 11, 2022

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741 is closed. What is the status of this PR?

vstinner commented Apr 19, 2022

Copy link
Copy Markdown
Member

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.

erlend-aasland commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

FYI, PEP-687 was just accepted.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
encukou changed the title bpo-1635741: Prep curses module for multi-phase init gh-103092: Prep curses module for multi-phase init Mar 28, 2024
bedevere-app Bot mentioned this pull request Mar 28, 2024
Closed
25 tasks

erlend-aasland commented May 8, 2024

Copy link
Copy Markdown
Contributor

Closing as per #101714 (comment). Thanks for the effort, Mohamed!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
shihai1991 shihai1991 left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Footer

© 2026 GitHub, Inc.