bpo-42222: Modernize integer test/conversion in randrange()#23064

rhettinger

Moves the int(x) == x test and conversion into the C code for operator.index().

Provides a 7% speed up:

$ pytime -s 'from random import randrange' 'randrange(15)' # baseline 500000 loops, best of 11: 540 nsec per loop $ pytime -s 'from random import randrange' 'randrange(15)' # new versio 500000 loops, best of 11: 502 nsec per loop

It should become even faster when we get a zero-cost try.

It's odd that non-integers raise a ValueError. I think that should have been TypeError.

https://bugs.python.org/issue42222

serhiy-storchaka

Currently you are on the way to #19112 (which already has tests and documentation and cover corner cases).

github-actions

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

serhiy-storchaka

What about #19112?

rhettinger

I merged in the relevant parts of #19112. The principal differences are:

The TypeError won't start being emitted until the after the deprecation period.
Improved wording for the doc entries.
Tests focus solely on the deprecations.
All existing behavior remains intact until after the deprecation.

serhiy-storchaka

The TypeError won't start being emitted until the after the deprecation period.

As in #19112 initially. I changed ValueError to TypeError on your request.

Improved wording for the doc entries.

I would appreciate any suggestions to change wording.

Tests focus solely on the deprecations.

Yes, tests in #19112 cover more cases.

All existing behavior remains intact until after the deprecation.

As well as in #19112.

But this PR still has issues. It does not emit warning for randrange(10, 20, 1.0).

bedevere-bot

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!

Use index() instead of testing int(x)==x

e11b1dc

rhettinger added the performance Performance or resource usage label Oct 31, 2020

rhettinger requested review from serhiy-storchaka and tim-one October 31, 2020 17:27

the-knights-who-say-ni added the CLA signed label Oct 31, 2020

bedevere-bot added the awaiting core review label Oct 31, 2020

rhettinger added 2 commits October 31, 2020 10:28

Add blurb

ebe8391

Deprecate float arguments and the ValueError

ed2f6fd

serhiy-storchaka reviewed Oct 31, 2020

View reviewed changes

serhiy-storchaka mentioned this pull request Oct 31, 2020

bpo-37319: Deprecated support of non-integer arguments in random.randrange(). #19112

Merged

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020

rhettinger removed the stale Stale PR or inactive for long period of time. label Dec 24, 2020

rhettinger added 4 commits December 24, 2020 00:32

Add more detail to blurb

ab9aeb7

Add tests

f32d175

Update the docs

ebcb257

Improve blurb

832d885

rhettinger added 2 commits December 24, 2020 14:20

Cover the case with a unit step

9e6945d

More concise blurb

85cc9ee

rhettinger merged commit a9621bb into python:master Dec 28, 2020

bedevere-bot removed the awaiting core review label Dec 28, 2020

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021

bpo-42222: Modernize integer test/conversion in randrange() (python#2… …

12cdba8

…3064)

AlexWaygood mentioned this pull request Feb 4, 2022

bpo-46066: Deprecate kwargs syntax for TypedDict definitions #31126

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-42222: Modernize integer test/conversion in randrange()#23064