← 返回首页
bpo-29940: Add follow_wrapped option to help() by eamanu · Pull Request #22390 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-29940: Add follow_wrapped option to help()#22390

Closed
eamanu wants to merge 9 commits into
python:masterfrom
eamanu:bpo-29940
Closed

bpo-29940: Add follow_wrapped option to help()#22390
eamanu wants to merge 9 commits into
python:masterfrom
eamanu:bpo-29940

Conversation

eamanu commented Sep 23, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

When print the docstring using help builtin for an wrapper function
it doesn't correspond to the function wrapped. For avoid this
this PR add the follow_wrapped option to help() function.

This is the continuation of the wrong #12915

cc: @chrahunt @taleinat

https://bugs.python.org/issue29940

eamanu and others added 9 commits September 22, 2020 21:11
Add follow_wrapped to help builtin …
088a5cc
When print the docstring using help builtin for an wrapper function it doesn't correspond to the function wrapped. For avoid this this PR add the follow_wrapped to help().
Add NEW
0af8ea8
Fix whitespace on Lib/pydoc.py
45dc1af
Change follow_wrapped parameter to be True for default
8f089f1
Update Lib/pydoc.py …
2832e99
Co-authored-by: Tal Einat <taleinat+github@gmail.com>
Fix pydoc to show successfully the documentation when the wrapped fun… …
e44927c
…c has doc. Otherwise show parents __doc__
Show help when __docs__ is available
997c8bd
add tests
f147a93
Fix code and test
54603ee
eamanu mentioned this pull request Sep 23, 2020
Closed

taleinat commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

It seems to me that the implementation approach here is strange, surprising, and could have unexpected consequences.

Why did you choose this rather than actually checking for wrapped, and following it (recursively) if found?

taleinat commented Sep 26, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Thanks for the PR, @eamanu, but this has already been resolved by PR GH-19479, as described and discussed in bpo-40257.

taleinat closed this Sep 26, 2020
eamanu deleted the bpo-29940 branch September 26, 2020 16:32
serhiy-storchaka mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.