← 返回首页
bpo-1635741: port scproxy to multi-phase init by koubaa · Pull Request #22164 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: port scproxy to multi-phase init#22164

Merged
corona10 merged 3 commits into
python:masterfrom
koubaa:bpo-1635741-scproxy
Sep 9, 2020
Merged

bpo-1635741: port scproxy to multi-phase init#22164
corona10 merged 3 commits into
python:masterfrom
koubaa:bpo-1635741-scproxy

Conversation

koubaa commented Sep 9, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

koubaa commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @shihai1991 @corona10 please review

corona10 requested changes Sep 9, 2020
View reviewed changes
Comment thread Modules/_scproxy.c Outdated Show resolved Hide resolved

bedevere-bot commented Sep 9, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Update Modules/_scproxy.c …
de604d2
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
corona10 closed this Sep 9, 2020
corona10 reopened this Sep 9, 2020
corona10 merged commit 3ff6975 into python:master Sep 9, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-1635741: port scproxy to multi-phase init (pythonGH-22164)
77fa3a3
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.