← 返回首页
bpo-1635741: testbuffer heap types by koubaa · Pull Request #22131 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: testbuffer heap types#22131

Closed
koubaa wants to merge 2 commits into
python:masterfrom
koubaa:bpo-1635741-testbuffer-heap-types
Closed

bpo-1635741: testbuffer heap types#22131
koubaa wants to merge 2 commits into
python:masterfrom
koubaa:bpo-1635741-testbuffer-heap-types

Conversation

koubaa commented Sep 7, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

koubaa commented Sep 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@vstinner @shihai1991 @corona10 I tried to take the conversions of just the heap types from #22003 in this PR. The tests are crashing here starting from the second commit (the staticarray conversion to a heap type did not cause any problems). I'm putting it up for review in case any of you could help me spot the problem.

multi-phase init, moving more globals to the module state, and any PEP7 style changes are going to come in a follow-up once I can identify the problems with this change.

shihai1991 reviewed Sep 8, 2020
View reviewed changes
Comment thread Modules/_testbuffer.c
staticarray_dealloc(StaticArrayObject *self)
{
PyTypeObject *tp = Py_TYPE(self);
PyObject_Del(self);

shihai1991 Sep 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

tp->tp_free(self) in here?

vstinner reviewed Sep 8, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

See compiler warnings at https://github.com/python/cpython/pull/22131/files , like:

‘ndarray_as_buffer’ defined but not used [-Wunused-variable]

skrah commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

This is a test module. The PR removes a test that explicitly tests static types at the request of @scoder .

It is not necessary to make changes to this module.

kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
shihai1991 shihai1991 left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.