← 返回首页
bpo-1635741: - port overlapped to multi-phase by koubaa · Pull Request #22051 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: - port overlapped to multi-phase#22051

Merged
vstinner merged 4 commits into
python:masterfrom
koubaa:bpo-1635741-overlapped
Sep 7, 2020
Merged

bpo-1635741: - port overlapped to multi-phase#22051
vstinner merged 4 commits into
python:masterfrom
koubaa:bpo-1635741-overlapped

Conversation

koubaa commented Sep 1, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

koubaa changed the title bro-1635741 - port overlapped to multi-phase bpo-1635741: - port overlapped to multi-phase Sep 1, 2020
corona10 reviewed Sep 2, 2020
View reviewed changes
Comment thread Modules/overlapped.c
overlapped_clear((PyObject *)module);
}

#define WINAPI_CONSTANT(fmt, con) \

corona10 Sep 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I think that this can be converted into PyModule_AddObject instead of using PyModule_GetDict

koubaa Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@corona10 You're right. Is that preferable to PyModule_GetDict? If so why?

corona10 Sep 3, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

https://docs.python.org/3/c-api/module.html?highlight=pymodule_getdict#c.PyModule_GetDict

It is recommended extensions use other PyModule_*() and PyObject_*() functions rather than directly manipulate a module’s __dict__.

koubaa Sep 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@corona10 I'm trying that now. So far it is not looking good - somehow the values are all wrong. For example when I switch to PyModule_AddObject, overlapped.__dict__["ERROR_IO_PENDING"] is 6160 instead of 997. I can't figure out why..

Edit - I figured it out. I was doing a decref on the object I passed into PyModule_AddObject, but it turns out this function steals the reference so I shouldn't do that.

koubaa commented Sep 6, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @shihai1991 @corona10 please review

vstinner approved these changes Sep 7, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, apart a typo in the NEWS entry. Please fix the NEWS entry, so I can merge your PR.

Comment thread Misc/NEWS.d/next/Core and Builtins/2020-09-01-17-22-35.bpo-1635741.CnRME3.rst Outdated
@@ -0,0 +1,2 @@
Port the :mod:`overlapped` extension module to multi-phase initialization

vstinner Sep 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The module is named "_overlapped" with an underscore.

Suggested change
Port the :mod:`overlapped` extension module to multi-phase initialization
Port the :mod:`_overlapped` extension module to multi-phase initialization

Comment thread Modules/overlapped.c Outdated

Py_DECREF(socket_module);

if (initialize_function_pointers() < 0)

vstinner Sep 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

While you modify the if, please add braces for consistency with the function (PEP 7).

vstinner merged commit 2aabc32 into python:master Sep 7, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
Merge remote-tracking branch 'origin/master' into bpo_1635741_1 …
00b300c
* origin/master: (1373 commits) bpo-1635741: Port mashal module to multi-phase init (python#22149) bpo-1635741: Port _string module to multi-phase init (pythonGH-22148) bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134) bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139) bpo-41732: add iterator to memoryview (pythonGH-22119) bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909) bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511) bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092) bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986) bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051) bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050) bpo-1635741 port zlib module to multi-phase init (pythonGH-21995) [doc] Add link to Generic in typing (pythonGH-22125) bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123) bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818) closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110) [doc] Fix padding in some typing definitions (pythonGH-22114) Fix documented Python version for venv --upgrade-deps (pythonGH-22113) bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581) bpo-41687: Fix sendfile implementation to work with Solaris (python#22040) ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051 …
b2a773d
) Port the _overlapped extension module to multi-phase initialization (PEP 489).
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 left review comments
vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.