← 返回首页
bpo-1635741: port opcode module to multi-phase init (PEP 489) by koubaa · Pull Request #22050 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: port opcode module to multi-phase init (PEP 489)#22050

Merged
vstinner merged 5 commits into
python:masterfrom
koubaa:bpo-1635741-opcode
Sep 7, 2020
Merged

bpo-1635741: port opcode module to multi-phase init (PEP 489)#22050
vstinner merged 5 commits into
python:masterfrom
koubaa:bpo-1635741-opcode

Conversation

koubaa commented Sep 1, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

koubaa commented Sep 1, 2020

Copy link
Copy Markdown
Contributor Author

@shihai1991 @vstinner I split this from the other PR

koubaa commented Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

I can't reproduce the windows test error locally. @vstinner could there be a flake in test_asyncio?

vstinner reviewed Sep 2, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I can't reproduce the windows test error locally. @vstinner could there be a flake in test_asyncio?

test_asyncio contains many race conditions. You're welcome to attempt to fix them :-) Search open issues in the "asyncio" component of https://bugs.python.org/ if you would like ot help.

Comment thread Modules/_opcode.c Outdated Show resolved Hide resolved
vstinner reviewed Sep 4, 2020
View reviewed changes
Comment thread Modules/_opcode.c Outdated
{NULL, NULL, 0, NULL}
};

static PyModuleDef_Slot opcode_slots[] = {

vstinner Sep 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This list is now empty and so became useless. Please remove it.

vstinner merged commit 426f2b4 into python:master Sep 7, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
Merge remote-tracking branch 'origin/master' into bpo_1635741_1 …
00b300c
* origin/master: (1373 commits) bpo-1635741: Port mashal module to multi-phase init (python#22149) bpo-1635741: Port _string module to multi-phase init (pythonGH-22148) bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134) bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139) bpo-41732: add iterator to memoryview (pythonGH-22119) bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909) bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511) bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092) bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986) bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051) bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050) bpo-1635741 port zlib module to multi-phase init (pythonGH-21995) [doc] Add link to Generic in typing (pythonGH-22125) bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123) bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818) closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110) [doc] Fix padding in some typing definitions (pythonGH-22114) Fix documented Python version for venv --upgrade-deps (pythonGH-22113) bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581) bpo-41687: Fix sendfile implementation to work with Solaris (python#22040) ...
koubaa deleted the bpo-1635741-opcode branch September 11, 2020 02:23
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pytho… …
13e530a
…nGH-22050)
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
shihai1991 shihai1991 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.