← 返回首页
bpo-1635741: port blake2 module to multi-phase init by koubaa · Pull Request #21856 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: port blake2 module to multi-phase init#21856

Merged
vstinner merged 11 commits into
python:masterfrom
koubaa:bpo-1635741-blake2
Sep 2, 2020
Merged

bpo-1635741: port blake2 module to multi-phase init#21856
vstinner merged 11 commits into
python:masterfrom
koubaa:bpo-1635741-blake2

Conversation

koubaa commented Aug 13, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

koubaa requested a review from tiran as a code owner August 13, 2020 12:23
koubaa mentioned this pull request Aug 13, 2020
Merged
koubaa force-pushed the bpo-1635741-blake2 branch from d282ca9 to abb51fe Compare August 21, 2020 23:49

koubaa commented Aug 29, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @shihai1991 This is ready for review

vstinner reviewed Aug 29, 2020
View reviewed changes
Comment thread Modules/_blake2/blake2b_impl.c Outdated Show resolved Hide resolved
Comment thread Modules/_blake2/blake2module.c Outdated Show resolved Hide resolved
Comment thread Modules/_blake2/blake2module.c Outdated Show resolved Hide resolved
Comment thread Modules/_blake2/blake2module.c Outdated Show resolved Hide resolved
Comment thread Modules/_blake2/blake2s_impl.c Outdated Show resolved Hide resolved
vstinner approved these changes Sep 1, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM, with a minor suggestion on the NEWS entry (please update it).

But right now, I cannot merge the PR: https://mail.python.org/archives/list/python-dev@python.org/thread/KMXK6BQWQZRR2TGVRLECMR7CUVIVTUMQ/

Please ping me when the workflow will be repaired, so I will merge your PR.

Comment thread Misc/NEWS.d/next/Core and Builtins/2020-08-13-07-18-05.bpo-1635741.FC13e7.rst Outdated Show resolved Hide resolved

koubaa commented Sep 1, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner looks like the doc issue is fixed in the CI.

vstinner merged commit a7f0268 into python:master Sep 2, 2020

vstinner commented Sep 2, 2020

Copy link
Copy Markdown
Member

Merged, thanks @koubaa.

corona10 mentioned this pull request Sep 10, 2020
Closed
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-1635741: Port _blake2 module to multi-phase init (pythonGH-21856) …
79cb7a5
Port the _blake2 extension module to the multi-phase initialization API (PEP 489).
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.