← 返回首页
bpo-41260: C impl of datetime.date.strftime() takes different keyword arg by ZackerySpytz · Pull Request #21712 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-41260: C impl of datetime.date.strftime() takes different keyword arg#21712

Merged
iritkatriel merged 2 commits into
python:mainfrom
ZackerySpytz:bpo-41260-datetime-strftime-param
Nov 25, 2022
Merged

bpo-41260: C impl of datetime.date.strftime() takes different keyword arg#21712
iritkatriel merged 2 commits into
python:mainfrom
ZackerySpytz:bpo-41260-datetime-strftime-param

Conversation

ZackerySpytz commented Aug 3, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The parameter was named "fmt" in the Python implementation, but it
was was named "format" in the C implementation.

https://bugs.python.org/issue41260

bpo-41260: C impl of datetime.date.strftime() takes different keyword… …
9132c91
… arg The parameter was named "fmt" in the Python implementation, but it was was named "format" in the C implementation.
asottile reviewed Aug 3, 2020
View reviewed changes

asottile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

oh uh, I was working through this with a beginner as a mentorship opportunity -- but the patch looks correct and equivalent to what we were doing

there's another function which should be updated as well which has a similar problem

asottile mannequin mentioned this pull request Apr 10, 2022
Closed

iritkatriel commented Nov 24, 2022

Copy link
Copy Markdown
Member

Should this be backported?

asottile commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Should this be backported?

I don't think so -- since it ~technically changes the signatures of the functions slightly

iritkatriel merged commit b1dcdef into python:main Nov 25, 2022
AlexWaygood mentioned this pull request Dec 4, 2022
Merged
AlexWaygood mentioned this pull request Dec 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pganssle pganssle approved these changes
abalkin Awaiting requested review from abalkin
+1 more reviewer
asottile asottile left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.