← 返回首页
bpo-1635741: Port sha256 module to multiphase init (PEP 489) by koubaa · Pull Request #21189 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: Port sha256 module to multiphase init (PEP 489)#21189

Merged
corona10 merged 4 commits into
python:masterfrom
koubaa:bpo-1635741-sha256
Jul 3, 2020
Merged

bpo-1635741: Port sha256 module to multiphase init (PEP 489)#21189
corona10 merged 4 commits into
python:masterfrom
koubaa:bpo-1635741-sha256

Conversation

koubaa commented Jun 27, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

koubaa requested a review from tiran as a code owner June 27, 2020 22:42

the-knights-who-say-ni commented Jun 27, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@koubaa

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

koubaa force-pushed the bpo-1635741-sha256 branch from bc4d566 to d63818d Compare June 27, 2020 22:45
koubaa force-pushed the bpo-1635741-sha256 branch from d63818d to 9f9e45a Compare June 28, 2020 21:23

koubaa commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

edtited the commit msg and repushed so that it would pick up the CLA which I signed yesterday. Not sure what the Misc/NEWS.d/next is about

shihai1991 reviewed Jun 29, 2020
View reviewed changes
Comment thread Modules/sha256module.c Outdated Show resolved Hide resolved
Comment thread Modules/sha256module.c Show resolved Hide resolved
Comment thread Modules/sha256module.c Outdated Show resolved Hide resolved

shihai1991 commented Jun 29, 2020

Copy link
Copy Markdown
Member

edtited the commit msg and repushed so that it would pick up the CLA which I signed yesterday. Not sure what the Misc/NEWS.d/next is about

If you add a feature which could effect the user, you should describe what you have changed in Misc/NEWS.d/next.
you can use a web service or cli to generate the description info:

A reference PR of Dong-hee Na:
c4862e3

vstinner reviewed Jun 30, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

cc @corona10

Comment thread Modules/sha256module.c Outdated Show resolved Hide resolved
corona10 requested changes Jun 30, 2020
View reviewed changes
Comment thread Modules/sha256module.c Outdated Show resolved Hide resolved

bedevere-bot commented Jun 30, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10 reviewed Jun 30, 2020
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

It's ok to convert static types to heap types in a separated PR.

If @vstinner is okay to make a separate PR for heap types.
I am also okay to merge this PR.

Please apply the review :)

corona10 changed the title bpo-1635741: Port sha56 module to multiphase init (PEP 489) bpo-1635741: Port sha256 module to multiphase init (PEP 489) Jun 30, 2020
vstinner reviewed Jul 2, 2020
View reviewed changes
Comment thread Modules/sha256module.c Outdated Show resolved Hide resolved

koubaa commented Jul 3, 2020

Copy link
Copy Markdown
Contributor Author

@corona10 any change still requested?

@shihai1991 @vstinner I started looking at doing heap types. First a disclaimer I'm new in this code so maybe I'm missing some context. I am seeing auto-generated files from clinic that don't take a module pointer as an input, so the module->state approach used by _gdbmmodule would only work if I could modify all of those auto-generated files (and presumably the system which generates them).

vstinner approved these changes Jul 3, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

@corona10, @shihai1991: Would you mind to review the change?

@corona10: Feel free to merge if the change looks good to you ;-)

corona10 approved these changes Jul 3, 2020
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM Thanks for the work!

corona10 merged commit 9d00697 into python:master Jul 3, 2020

shihai1991 commented Jul 3, 2020

Copy link
Copy Markdown
Member

oh, sorry, I am late, LGTM.

koubaa deleted the bpo-1635741-sha256 branch August 28, 2020 00:21
kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shihai1991 shihai1991 left review comments
vstinner vstinner approved these changes
corona10 corona10 approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.