← 返回首页
gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing by asottile · Pull Request #21104 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing#21104

Merged
iritkatriel merged 2 commits into
python:mainfrom
asottile:inspect_signature_simplify
Nov 27, 2022
Merged

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing#21104
iritkatriel merged 2 commits into
python:mainfrom
asottile:inspect_signature_simplify

Conversation

asottile commented Jun 24, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

asottile force-pushed the inspect_signature_simplify branch from 5309efa to 847fd9f Compare September 3, 2020 18:10
asottile force-pushed the inspect_signature_simplify branch from 847fd9f to e569169 Compare November 2, 2021 02:24
asottile force-pushed the inspect_signature_simplify branch from e569169 to 477c2eb Compare July 8, 2022 16:27
asottile force-pushed the inspect_signature_simplify branch from 477c2eb to 83f9192 Compare August 5, 2022 20:22

asottile commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

@1st1 (inspect expert) -- been sitting on this small fix for a few years -- any chance of a review ?

asottile force-pushed the inspect_signature_simplify branch from 83f9192 to e6eaf8e Compare October 5, 2022 21:16
iritkatriel changed the title Simplify routine in inspect.signature parsing remove unused 'invalid' variable in inspect.signature parsing Nov 27, 2022
iritkatriel changed the title remove unused 'invalid' variable in inspect.signature parsing remove unused 'invalid' value in inspect.signature parsing Nov 27, 2022
iritkatriel changed the title remove unused 'invalid' value in inspect.signature parsing gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing Nov 27, 2022
bedevere-bot mentioned this pull request Nov 27, 2022
Closed
iritkatriel merged commit ac115b5 into python:main Nov 27, 2022
JelleZijlstra mentioned this pull request Dec 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
+1 more reviewer
eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.