← 返回首页
bpo-40521: Empty frozenset is no longer a singleton by rhettinger · Pull Request #21085 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-40521: Empty frozenset is no longer a singleton#21085

Merged
vstinner merged 3 commits into
python:masterfrom
rhettinger:empty_frozenset
Jun 23, 2020
Merged

bpo-40521: Empty frozenset is no longer a singleton#21085
vstinner merged 3 commits into
python:masterfrom
rhettinger:empty_frozenset

Conversation

rhettinger commented Jun 23, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Making the empty frozenset a singleton wasn't worth it. Unlike empty strings and empty tuples, these are not common and don't warrant a special case. Taking it out makes the code simpler.

https://bugs.python.org/issue40521

rhettinger requested a review from tiran as a code owner June 23, 2020 15:02
vstinner approved these changes Jun 23, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

vstinner merged commit f9bd05e into python:master Jun 23, 2020

vstinner commented Jun 23, 2020

Copy link
Copy Markdown
Member

I merged the PR since I'm working on other changes which are in conflict with this PR, like PR #21086.

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
bpo-40521: Empty frozenset is no longer a singleton (pythonGH-21085) …
657f2bd
* Revert "bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)" This reverts commit 261cfed. * bpo-40521: Empty frozensets are no longer singletons * Complete the removal of the frozenset singleton
vstinner mentioned this pull request Apr 10, 2022
Closed
This was referenced Jul 5, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.