← 返回首页
bpo-32604: Disable failing tests by nanjekyejoannah · Pull Request #20777 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-32604: Disable failing tests#20777

Merged
nanjekyejoannah merged 1 commit into
python:masterfrom
nanjekyejoannah:fix_race
Jun 21, 2020
Merged

bpo-32604: Disable failing tests#20777
nanjekyejoannah merged 1 commit into
python:masterfrom
nanjekyejoannah:fix_race

Conversation

nanjekyejoannah commented Jun 10, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

I decided to skip the tests in question until I get time to fix the races.

Requesting a second eye @pablogsal and @vstinner if this makes the bots green.

https://bugs.python.org/issue32604

bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 10, 2020
ericsnowcurrently approved these changes Jun 17, 2020
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

I'll see if we can track down the problem by the end of the week and get those tests re-enabled.

vstinner commented Jun 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The PR title is very misleading: "bpo-32604: PEP 554 implementation: add interpreters module #20777".

nanjekyejoannah changed the title bpo-32604: PEP 554 implementation: add interpreters module bpo-32604: Disable failing tests Jun 17, 2020
nanjekyejoannah merged commit 6f79838 into python:master Jun 21, 2020

nanjekyejoannah commented Jun 22, 2020

Copy link
Copy Markdown
Contributor Author

Merging until we get a fix @ericsnowcurrently

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
Skip tests to fix bot (pythonGH-20777) …
69b3080
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
vstinner Awaiting requested review from vstinner
pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.