← 返回首页
bpo-2897: Make PyMemberDef part of stable ABI; deprecate structmember.h by MatzeB · Pull Request #20462 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-2897: Make PyMemberDef part of stable ABI; deprecate structmember.h#20462

Closed
MatzeB wants to merge 1 commit into
python:mainfrom
MatzeB:fix-issue-2897
Closed

bpo-2897: Make PyMemberDef part of stable ABI; deprecate structmember.h#20462
MatzeB wants to merge 1 commit into
python:mainfrom
MatzeB:fix-issue-2897

Conversation

MatzeB commented May 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Move PyMemberDef and related flags from structmember.h to descrobject.h.
Rename READONLY to PY_READONLY and READ_RESTRICTED to
PY_READ_RESTRICTED. This makes the structure part of the stable ABI.

Move PyMember_GetOne and PyMemberSetOne as well but do not make them
part of the stable ABI yet.

Document that structmember.h is deprecated, change examples and
documentation and add definitions for READONLY, READ_RESTRICTED,
PY_WRITE_RESTRICTED and RESTRICTED to it for backwards compatibility.

Add check for stddef.h to configure.ac because we need to include it for
offsetof and Python.h does not pass the HAVE_STDDEF_H check without it.

https://bugs.python.org/issue2897

bpo-2897: Make PyMemberDef part of stable ABI; deprecate structmember.h …
56276cd
Move PyMemberDef and related flags from structmember.h to descrobject.h. Rename READONLY to PY_READONLY and READ_RESTRICTED to PY_READ_RESTRICTED. This makes the structure part of the stable ABI. Move PyMember_GetOne and PyMemberSetOne as well but do not make them part of the stable ABI yet. Document that structmember.h is deprecated, change examples and documentation and add definitions for READONLY, READ_RESTRICTED, PY_WRITE_RESTRICTED and RESTRICTED to it for backwards compatibility. Add check for stddef.h to configure.ac because we need to include it for offsetof and Python.h does not pass the HAVE_STDDEF_H check without it.
erlend-aasland mentioned this pull request Oct 6, 2020
Closed
tiran removed their request for review April 17, 2021 21:23
rhettinger removed their request for review May 3, 2022 06:07

encukou commented Oct 10, 2022

Copy link
Copy Markdown
Member

Hello. Sorry for the delay -- I just found this PR (I noticed the bug and wanted to file an issue myself).
Are you still interested in the PR, after 2 years?
If not, I'd be happy to take over.

  • Changing all the uses of READONLY to PY_READONLY (and removing the #include) isn't really necessary. The PR would be much easier to review without that, and there'd be fewer conflicts.
  • Everything included from Python.h should have the Py_ prefix, so T_* macros should be renamed to PY_T_*. The old header should continue to provide the old names.
    • The new constants should be documented and added to Misc/stable_abi.toml, but let's do that in a separate PR.
  • We should ensure we don't reuse PY_WRITE_RESTRICTED's value for something else in the future. So, in descrobject.h, I would #define _PY_WRITE_RESTRICTED 4 with an appropriate comment. (Note the leading underscore.)
  • The configure*, Python.h and HAVE_STDDEF_H stuff shouldn't change here. structmember.h should include stddef.h for backward compatibility, but the other stuff can be left to other PRs/issues, if necessary.
  • This needs an entry in What's New.

MatzeB commented Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

Hey, I am currently not working with python so I don't know when I would find the time to push this further. If you or someone else wants to take over, by all means!

benjaminp mentioned this pull request Apr 10, 2022
Closed

encukou commented Nov 2, 2022

Copy link
Copy Markdown
Member

Taking over in #99014

encukou closed this Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
abalkin Awaiting requested review from abalkin
berkerpeksag Awaiting requested review from berkerpeksag
pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.