← 返回首页
[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (GH-18007) by akuchling · Pull Request #20092 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (GH-18007)#20092

Merged
miss-islington merged 2 commits into
python:3.8from
akuchling:backport-d72ea60-3.8
May 29, 2020
Merged

[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (GH-18007)#20092
miss-islington merged 2 commits into
python:3.8from
akuchling:backport-d72ea60-3.8

Conversation

akuchling commented May 14, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Backporting to 3.8 and adding a NEWS item (I should have added one to the master branch -- oh well).

https://bugs.python.org/issue25872

Automerge-Triggered-By: @csabella

mgraczyk and others added 2 commits May 14, 2020 13:26
[3.8] bpo-25872: Fix KeyError using linecache from multiple threads (p… …
45240f6
…ythonGH-18007) The crash that this fixes occurs when using traceback and other modules from multiple threads; del cache[filename] can raise a KeyError. (cherry picked from commit d72ea60) Co-authored-by: Michael Graczyk <mgraczyk@users.noreply.github.com>
[3.8] bpo-25872: Add NEWS.d item
91eeeec
csabella approved these changes May 29, 2020
View reviewed changes

csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm

miss-islington merged commit b86636b into python:3.8 May 29, 2020

miss-islington commented May 29, 2020

Copy link
Copy Markdown
Contributor

Thanks @akuchling for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2020
[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (python… …
0fe973a
…GH-18007) (pythonGH-20092) Backporting to 3.8 and adding a NEWS item (I should have added one to the master branch -- oh well). (cherry picked from commit b86636b) Co-authored-by: Andrew Kuchling <amk@amk.ca>

bedevere-bot commented May 29, 2020

Copy link
Copy Markdown

GH-20511 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 29, 2020
[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (GH-18007… …
852e8a7
…) (GH-20092) Backporting to 3.8 and adding a NEWS item (I should have added one to the master branch -- oh well). (cherry picked from commit b86636b) Co-authored-by: Andrew Kuchling <amk@amk.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

csabella csabella approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Footer

© 2026 GitHub, Inc.