← 返回首页
bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows. by serhiy-storchaka · Pull Request #20035 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows.#20035

Closed
serhiy-storchaka wants to merge 2 commits into
python:masterfrom
serhiy-storchaka:isidentifier-legacy
Closed

bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows.#20035
serhiy-storchaka wants to merge 2 commits into
python:masterfrom
serhiy-storchaka:isidentifier-legacy

Conversation

serhiy-storchaka commented May 11, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label May 11, 2020
vstinner reviewed May 11, 2020
View reviewed changes
Comment thread Objects/unicodeobject.c Outdated
{
/* Since there is no way to return an error from PyUnicode_IsIdentifier()
we have to call PyUnicode_READY() to ensure that the string object is
in the "canonical" representation. */

vstinner May 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I don't think that this comment is worth it. It's something usual to report an error when a function fails. All functions in this file does that. I suggest to remove the comment.

Comment thread Objects/typeobject.c Outdated Show resolved Hide resolved
serhiy-storchaka commented May 12, 2020
View reviewed changes
Comment thread Objects/unicodeobject.c Outdated Show resolved Hide resolved
Apply suggestions from code review …
750d91f
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka mentioned this pull request May 12, 2020
Merged
serhiy-storchaka deleted the isidentifier-legacy branch May 12, 2020 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

awaiting core review type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.