← 返回首页
bpo-40328: Add tool for generating cjk mapping headers by corona10 · Pull Request #19602 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-40328: Add tool for generating cjk mapping headers#19602

Merged
corona10 merged 14 commits into
python:masterfrom
corona10:bpo-40328
Apr 29, 2020
Merged

bpo-40328: Add tool for generating cjk mapping headers#19602
corona10 merged 14 commits into
python:masterfrom
corona10:bpo-40328

Conversation

corona10 commented Apr 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10 changed the title bpo-40328: Add tool for generating mapping headers. bpo-40328: Add tool for generating mapping headers Apr 19, 2020
corona10 requested a review from vstinner April 19, 2020 13:29

corona10 commented Apr 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@vstinner
If this repository would not be a proper place to store files under tool/data
Is it okay to create a new repository for this? (it's too huge)
But files need to be stored somewhere in our manageable place since
these files can be broken and loose when the times are passed.
(e.g http://www.info.gov.hk/digital21/eng/hkscs/download/big5-iso.txt is broken now.)

corona10 requested a review from methane April 19, 2020 13:33
corona10 changed the title bpo-40328: Add tool for generating mapping headers bpo-40328: Add tool for generating cjk mapping headers Apr 19, 2020
vstinner reviewed Apr 20, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I would prefer to put this script in Tools/unicode/ and don't store Unicode files in Modules/cjkcodecs/tools/data/CP932.TXT, but always download them: as done by Tools/unicode/makeunicodedata.py or some unit tests.

corona10 requested a review from vstinner April 20, 2020 14:48
corona10 commented Apr 20, 2020
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@vstinner Please take a look :)

corona10 commented Apr 21, 2020

Copy link
Copy Markdown
Member Author

@methane @serhiy-storchaka
Also, Can you please take look at this PR?

methane commented Apr 23, 2020

Copy link
Copy Markdown
Member

I don't have time to understand the script. I only confirmed that this pull request doesn't change the mapping header files.

corona10 commented Apr 23, 2020

Copy link
Copy Markdown
Member Author

@methane
Thank you Naoki San!
The main objective of this PR is generating the same mapping header files :)
For example, we can make some change with this script when
something needs to change about supporting Japanese.
(I don't know the practical case)

corona10 commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

@vstinner Can we merge this PR?

vstinner reviewed Apr 29, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Should we run this script in "make regen-all"? Or do you expect that these generated files will never ever change?

Currently, "make regen-all" has no 3rd party dependencies, whereas this script requires to download files from the Internet. In my experience, any additional external dependency makes Python CIs less stable :-(

Other "unicode scripts" are no run by "make regen-all", so I think that it's fine.

vstinner commented Apr 29, 2020

Copy link
Copy Markdown
Member

@corona10: I let you decide if you are confident enough to merge this PR with no review.

Since this script is not run by any CI and only run manually, I don't see any risk of regression.

It seems like "Unicode experts" (including me) don't have the bandwidth to review your change.

corona10 merged commit 113feb3 into python:master Apr 29, 2020
corona10 mentioned this pull request May 4, 2022
Closed
corona10 deleted the bpo-40328 branch May 11, 2022 05:55
ezio-melotti mentioned this pull request May 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
methane Awaiting requested review from methane
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.