← 返回首页
bpo-1635741: Port mmap module to multiphase initialization by corona10 · Pull Request #19459 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-1635741: Port mmap module to multiphase initialization#19459

Merged
corona10 merged 4 commits into
python:masterfrom
corona10:bpo-1635741-mmap
Jun 5, 2020
Merged

bpo-1635741: Port mmap module to multiphase initialization#19459
corona10 merged 4 commits into
python:masterfrom
corona10:bpo-1635741-mmap

Conversation

corona10 commented Apr 10, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10 changed the title Port mmap module to multiphase initialization bpo-1635741: Port mmap module to multiphase initialization Apr 10, 2020
corona10 requested a review from vstinner April 10, 2020 15:31
shihai1991 approved these changes Apr 10, 2020
View reviewed changes

shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM ;)

vstinner approved these changes Jun 5, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM. mmap code would deserve better error handling, but that can be addressed in a separated PR.

Apart static types, I don't anything which would be shared by multiple module instances/interpreters.

Comment thread Modules/mmapmodule.c Outdated Show resolved Hide resolved
Comment thread Modules/mmapmodule.c Outdated Show resolved Hide resolved
corona10 force-pushed the bpo-1635741-mmap branch from 623259b to d3b55d7 Compare June 5, 2020 13:52
vstinner reviewed Jun 5, 2020
View reviewed changes
Comment thread Modules/mmapmodule.c Show resolved Hide resolved
vstinner reviewed Jun 5, 2020
View reviewed changes
Comment thread Modules/mmapmodule.c Outdated Show resolved Hide resolved
vstinner approved these changes Jun 5, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM apart the PyExc_OSError bug.

corona10 merged commit 3ad52e3 into python:master Jun 5, 2020

corona10 commented Jun 5, 2020

Copy link
Copy Markdown
Member Author

@vstinner @shihai1991 Thanks for the reviews!

kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
corona10 deleted the bpo-1635741-mmap branch February 15, 2024 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
shihai1991 shihai1991 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.