← 返回首页
[WIP] bpo-1635741: Port _collections module to multiphase initialization. by corona10 · Pull Request #19071 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[WIP] bpo-1635741: Port _collections module to multiphase initialization.#19071

Closed
corona10 wants to merge 1 commit into
python:masterfrom
corona10:bpo-1635741-_collectionsmodule
Closed

[WIP] bpo-1635741: Port _collections module to multiphase initialization.#19071
corona10 wants to merge 1 commit into
python:masterfrom
corona10:bpo-1635741-_collectionsmodule

Conversation

corona10 commented Mar 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10 requested a review from rhettinger as a code owner March 19, 2020 14:35
corona10 commented Mar 19, 2020
View reviewed changes
Comment thread Modules/_collectionsmodule.c Outdated

corona10 Mar 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@vstinner I'd like to create a new helper function for this.

This logic can be reused.
https://github.com/python/cpython/blob/514c469719f149e1722a91a9d0c63bf89dfefb2a/Modules/itertoolsmodule.c#L4733L4747

What do you think?

vstinner Mar 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Do you mean combine PyType_Ready + _PyType_Name + PyModule_AddObject? Yeah, maybe it's worth it, but I would prefer to add it once this PR lands.

corona10 changed the title bpo-1635741: Port _collections module to multiphase initialization. [WIP] bpo-1635741: Port _collections module to multiphase initialization. Mar 19, 2020
corona10 force-pushed the bpo-1635741-_collectionsmodule branch from 58e7344 to fb35d81 Compare March 19, 2020 14:46
vstinner reviewed Mar 19, 2020
View reviewed changes
Comment thread Modules/_collectionsmodule.c
&PyODict_Type,
&dequeiter_type,
&dequereviter_type,
&tuplegetter_type,

vstinner Mar 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Either you use Py_ARRAY_COUNT() to get the list length, or you need to add a NULL terminator. Currently, you rely on an undefined behavior.

corona10 closed this Mar 19, 2020
corona10 mentioned this pull request Mar 19, 2020
Merged

shihai1991 commented Mar 19, 2020

Copy link
Copy Markdown
Member

FWIW, some comments in https://github.com/python/cpython/pull/18066/files

kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.