← 返回首页
Rename Doc/README.txt to Doc/README.rst · Pull Request #19 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Rename Doc/README.txt to Doc/README.rst#19

Closed
ghost wants to merge 5 commits into
masterfrom
unknown repository
Closed

Rename Doc/README.txt to Doc/README.rst#19
ghost wants to merge 5 commits into
masterfrom
unknown repository

Conversation

ghost commented Feb 11, 2017

Copy link
Copy Markdown

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

the-knights-who-say-ni commented Feb 11, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

methane requested changes Feb 11, 2017
View reviewed changes
Comment thread Doc/make.bat
echo.
echo.All arguments past the first one are passed through to sphinx-build as
echo.filenames to build or are ignored. See README.txt in this directory or
echo.filenames to build or are ignored. See README.rst in this directory or

methane Feb 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Doc/README.txt is still alive.

zware Feb 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This PR renames Doc/README.txt to Doc/README.rst.

methane Feb 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Ah, I'm sorry. I misundersttod.

methane approved these changes Feb 11, 2017
View reviewed changes
Comment thread Doc/make.bat
echo.
echo.All arguments past the first one are passed through to sphinx-build as
echo.filenames to build or are ignored. See README.txt in this directory or
echo.filenames to build or are ignored. See README.rst in this directory or

methane Feb 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Ah, I'm sorry. I misundersttod.

methane commented Feb 11, 2017

Copy link
Copy Markdown
Member

I think we don't require CLA sign for pull requests like this.

orsenthil commented Feb 11, 2017

Copy link
Copy Markdown
Member

@methane , any patch / contribution requires CLA sign.

ghost commented Feb 11, 2017

Copy link
Copy Markdown
Author

I signed it an hour ago.

methane mentioned this pull request Feb 11, 2017
Merged

methane commented Feb 11, 2017

Copy link
Copy Markdown
Member

Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)

vstinner requested changes Feb 12, 2017
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.

ghost commented Feb 12, 2017 •
edited by ghost
Loading

Copy link
Copy Markdown
Author

@methane MY CLA still has not been marked, and I currently have this:

It's been two days since I submitted it, any update?

vstinner commented Feb 12, 2017

Copy link
Copy Markdown
Member

Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch.

ghost commented Feb 12, 2017

Copy link
Copy Markdown
Author

No, it was made in the master branch @Haypo

ghost commented Feb 12, 2017

Copy link
Copy Markdown
Author

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

vstinner commented Feb 13, 2017

Copy link
Copy Markdown
Member

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

Look at README.rst in the root directory.

vstinner requested changes Feb 13, 2017
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I suggested different text where [...] is the link.

Comment thread Doc/README.rst Outdated

Bugs in the toolset should be reported in the Sphinx bug tracker at
https://www.bitbucket.org/birkenfeld/sphinx/issues/.
`bitbucket.org/birkenfeld/sphinx/issues/ <https://www.bitbucket.org/birkenfeld/sphinx/issues/>`_.

vstinner Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I suggest "Bugs in the toolset should be reported in the [Sphinx bug tracker]."

Comment thread Doc/README.rst Outdated
@@ -109,10 +109,10 @@ Contributing
============

Bugs in the content should be reported to the Python bug tracker at

vstinner Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

"Bugs in the content should be reported to the [Python bug tracker]."

Comment thread Doc/README.rst Outdated
You need to have `Sphinx <http://sphinx-doc.org/>`_ installed; it is the toolset
used to build the docs. It is not included in this tree, but maintained
separately and available from PyPI <https://pypi.python.org/pypi/Sphinx>.
separately and available from `PyPI <https://pypi.python.org/pypi/Sphinx>`_.

vstinner Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

and [available from PyPI].

Comment thread Doc/README.rst Outdated
This directory contains the reStructuredText (reST) sources to the Python
documentation. You don't need to build them yourself, prebuilt versions are
available at <https://docs.python.org/dev/download.html>.
available at `docs.python.org/dev/download.html <https://docs.python.org/dev/download.html>`_.

vstinner Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

..., [prebuilt versions are available].

ghost commented Feb 13, 2017 •
edited by ghost
Loading

Copy link
Copy Markdown
Author

The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address is narayan<>roger<>@<>gmail.com (remove the <>)

codecov Bot commented Feb 13, 2017

Copy link
Copy Markdown

Codecov Report

Merging #19 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #19 +/- ## ========================================== - Coverage 82.37% 82.37% -0.01% ========================================== Files 1427 1427 Lines 350948 350948 ========================================== - Hits 289091 289089 -2 - Misses 61857 61859 +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29896ad...08cb2a3. Read the comment docs.

ghost commented Feb 13, 2017

Copy link
Copy Markdown
Author

@Haypo The changes you requested were made

7 hidden items Load more…
paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019
Merge pull request python#19 from paulmon/fix-venvlauncher …
bbac193
Fix venvlauncher
pablogsal mentioned this pull request Jun 12, 2020
Closed
itachaaa mentioned this pull request Aug 22, 2022
Open
mdboom mentioned this pull request Aug 25, 2022
Closed
mdboom mentioned this pull request Nov 22, 2022
Closed
ziegenbalg mentioned this pull request Nov 30, 2022
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
If PR author is the same as the committer, only mention them once. (G… …
b72583c
…H-19) Closes python/miss-islington#18
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Feb 1, 2023
Merge python#19 …
5f5332a
19: Warn for range and xrange r=ltratt a=nanjekyejoannah See notes: ``` Py2.x: >>> x = xrange(1, 10000) >>> a = range(1,10000) >>> type(a) <type 'list'> >>> Py3.x: >>> x = xrange(1, 10000) Traceback (most recent call last): File "<stdin>", line 1, in <module> NameError: name 'xrange' is not defined >>> a = range(1,10000) >>> type(a) <class 'range'> >>> ``` Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
fix: off by one error in forward jump calculation (python#19) …
f876fdb
* fix: off by one error in forward jump calculation * Test: fixed test for python#18 * test: remove broken test --------- Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
gvanrossum mentioned this pull request Aug 22, 2023
Closed
LinanV mentioned this pull request Oct 23, 2023
Closed
stasos24 mentioned this pull request Oct 24, 2023
Closed
williamhu020 mentioned this pull request Nov 5, 2023
Closed
kcatss mentioned this pull request Nov 15, 2023
Closed
kcatss mentioned this pull request Jan 14, 2024
Closed
kcatss mentioned this pull request Feb 12, 2024
Closed
kcatss mentioned this pull request Feb 20, 2024
Closed
ngoldbaum mentioned this pull request Sep 23, 2024
Closed
Dean6767 mentioned this pull request Feb 10, 2025
Closed
This was referenced Feb 11, 2025
Closed
Closed
DominiquePACCO mentioned this pull request Jun 3, 2025
Closed
efimov-mikhail mentioned this pull request Nov 5, 2025
Open
youknowone referenced this pull request in youknowone/cpython Nov 20, 2025
Fix cargo path and add CARGO_TARGET for cross compile (#19) …
071b7f1
There are still some issues with compilation, but those can be sorted out in a future PR.
ZeroIntensity pushed a commit to ZeroIntensity/cpython that referenced this pull request Dec 8, 2025
Merge pull request python#19 from DinoV/lazy_tests_dunder
b743eb0
sergey-miryanov mentioned this pull request Dec 18, 2025
Closed
Qanux mentioned this pull request Feb 11, 2026
Closed
ngoldbaum mentioned this pull request Mar 6, 2026
Open
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.