← 返回首页
bpo-30514: test_pop3lib asyncore with asyncio by grzgrzgrz3 · Pull Request #1864 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-30514: test_pop3lib asyncore with asyncio#1864

Open
grzgrzgrz3 wants to merge 2 commits into
python:mainfrom
grzgrzgrz3:bpo30514-grzegorz-grzywacz-poplib
Open

bpo-30514: test_pop3lib asyncore with asyncio#1864
grzgrzgrz3 wants to merge 2 commits into
python:mainfrom
grzgrzgrz3:bpo30514-grzegorz-grzywacz-poplib

Conversation

grzgrzgrz3 commented May 30, 2017 •
edited by JelleZijlstra
Loading

Copy link
Copy Markdown
Contributor

Pop3 server stub was base on asyncore/asynchat which is deprecated, new
stub is using asyncio instead.

test_too_long_lines make sure we read remaining overlong response

cmd_user answer only with +ERR message on invalid user

#74699

bpo-30514: test_pop3lib asyncore with asyncio …
db49288
Pop3 server stub was base on asyncore/asynchat which is deprecated, new stub is using asyncio instead. test_too_long_lines make sure we read remaining overlong response cmd_user answer only with +ERR message on invalid user

mention-bot commented May 30, 2017

Copy link
Copy Markdown

@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @serhiy-storchaka and @giampaolo to be potential reviewers.

codecov Bot commented May 30, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@9c972b5). Click here to learn what that means.
The diff coverage is 97.67%.

@@ Coverage Diff @@ ## master #1864 +/- ## ========================================= Coverage ? 82.68% ========================================= Files ? 1432 Lines ? 353405 Branches ? 0 ========================================= Hits ? 292229 Misses ? 61176 Partials ? 0
Impacted Files Coverage Δ
Lib/test/test_poplib.py 98.13% <97.67%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c972b5...996e0cc. Read the comment docs.

serhiy-storchaka added the tests Tests in the Lib/test dir label Dec 8, 2018
matrixise self-assigned this Sep 12, 2019
auvipy suggested changes Jul 20, 2021
View reviewed changes

auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

a rebase on top of main branch would be a good first start

matrixise removed their assignment Oct 5, 2021

github-actions Bot commented Feb 19, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
grzgrzgrz3 mannequin mentioned this pull request Apr 11, 2022
Open
JelleZijlstra self-assigned this May 10, 2022

JelleZijlstra commented May 10, 2022

Copy link
Copy Markdown
Member

I'll work on getting this up to date so it unblocks removing asyncore. Note to self: local branch name is bpo30514-grzegorz-grzywacz-poplib.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 11, 2022
JelleZijlstra mentioned this pull request May 26, 2022
Closed
12 tasks

AA-Turner commented Jun 7, 2022

Copy link
Copy Markdown
Member

Triggering CLA.

AA-Turner closed this Jun 7, 2022
AA-Turner reopened this Jun 7, 2022

github-actions Bot commented Jul 8, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 8, 2022
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Oct 10, 2022

github-actions Bot commented Nov 10, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 10, 2022
JelleZijlstra removed their assignment Nov 12, 2022
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 13, 2022

github-actions Bot commented Dec 14, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
auvipy auvipy requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time. tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Footer

© 2026 GitHub, Inc.