← 返回首页
bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h by ncoghlan · Pull Request #18052 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h#18052

Merged
ncoghlan merged 1 commit into
python:masterfrom
ncoghlan:move-frameobject-header
Jan 20, 2020
Merged

bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h#18052
ncoghlan merged 1 commit into
python:masterfrom
ncoghlan:move-frameobject-header

Conversation

ncoghlan commented Jan 18, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The patch for PEP 558 (bpo-30744) adds a number of new frame-related
C APIs. This prepatory patch migrates frameobject.h to the modern layout
with multiple include files so the PEP reference implementation can clearly
separate the stable ABI additions from the full CPython C API additions.

https://bugs.python.org/issue35134

ncoghlan requested a review from vstinner January 18, 2020 13:51
ncoghlan mentioned this pull request Jan 18, 2020
Closed
27 tasks
vstinner approved these changes Jan 19, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM. You can use bpo-35134 in the commit title if you want.

ncoghlan changed the title Migrate frameobject.h contents to cpython/frameobject.h bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h Jan 20, 2020
ncoghlan merged commit 1e420f8 into python:master Jan 20, 2020
ncoghlan deleted the move-frameobject-header branch January 20, 2020 22:21

ncoghlan commented Jan 20, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review!

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h (p… …
6f10493
…ythonGH-18052)
njsmith mentioned this pull request Apr 10, 2022
Closed
vstinner mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.