← 返回首页
bpo-33166: Change os.cpu_count to return active (real) processors by zooba · Pull Request #15949 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-33166: Change os.cpu_count to return active (real) processors#15949

Merged
zware merged 3 commits into
python:masterfrom
zooba:bpo-33166
Sep 11, 2019
Merged

bpo-33166: Change os.cpu_count to return active (real) processors#15949
zware merged 3 commits into
python:masterfrom
zooba:bpo-33166

Conversation

zooba commented Sep 11, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.8 labels Sep 11, 2019

zooba commented Sep 11, 2019

Copy link
Copy Markdown
Member Author

Note that I added the prototype rather than changing the Windows version in pyconfig.h. This is so it's safe to backport to 3.8.

In a later PR I'll update the API version.

zware requested changes Sep 11, 2019
View reviewed changes
Comment thread Modules/posixmodule.c Show resolved Hide resolved

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

zooba commented Sep 11, 2019

Copy link
Copy Markdown
Member Author

I don't want to backport the WINNT_VER change because we have so much stuff that tries to auto-detect macros, and that may introduce new macros. It's a little late in the release cycle for that.

zooba commented Sep 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

Ping @zware

zware approved these changes Sep 11, 2019
View reviewed changes

zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

zooba mentioned this pull request Sep 11, 2019
Merged
zware merged commit aa92927 into python:master Sep 11, 2019

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-33166: Change os.cpu_count to return active (real) processors (py… …
a9475d6
…thonGH-15949) (cherry picked from commit aa92927) Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15979 is a backport of this pull request to the 3.8 branch.

zooba deleted the bpo-33166 branch September 11, 2019 15:16
miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-33166: Change os.cpu_count to return active (real) processors (GH… …
43ee0e2
…-15949) (cherry picked from commit aa92927) Co-authored-by: Steve Dower <steve.dower@python.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
bpo-33166: Change os.cpu_count to return active (real) processors (py… …
71dc9e0
…thonGH-15949)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zware zware approved these changes

Assignees

No one assigned

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.