← 返回首页
[3.8] bpo-28009: Fix uuid SkipUnless logic to be based on platform programs capable of introspection (GH-12777) by miss-islington · Pull Request #14115 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.8] bpo-28009: Fix uuid SkipUnless logic to be based on platform programs capable of introspection (GH-12777)#14115

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-3a1d50e-3.8
Jun 15, 2019
Merged

[3.8] bpo-28009: Fix uuid SkipUnless logic to be based on platform programs capable of introspection (GH-12777)#14115
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-3a1d50e-3.8

Conversation

miss-islington commented Jun 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

uuid could try fallback methods that had no chance of working on a particular
platform, and this could cause spurious test failures, as well as degraded
performance as fallback options were tried and failed.

This fixes both the uuid module and its test's SkipUnless logic to use a
prefiltered list of techniques that may at least potentially work on that platform.

Patch by Michael Felt (aixtools).
(cherry picked from commit 3a1d50e)

Co-authored-by: Michael Felt aixtools@users.noreply.github.com

https://bugs.python.org/issue28009

bpo-28009: Fix uuid SkipUnless logic to be based on platform programs… …
5898be2
… capable of introspection (pythonGH-12777) uuid could try fallback methods that had no chance of working on a particular platform, and this could cause spurious test failures, as well as degraded performance as fallback options were tried and failed. This fixes both the uuid module and its test's SkipUnless logic to use a prefiltered list of techniques that may at least potentially work on that platform. Patch by Michael Felt (aixtools). (cherry picked from commit 3a1d50e) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
bedevere-bot mentioned this pull request Jun 15, 2019
Merged

miss-islington commented Jun 15, 2019

Copy link
Copy Markdown
Contributor Author

@aixtools and @ncoghlan: Status check is done, and it's a success ✅ .

miss-islington merged commit f0e5c01 into python:3.8 Jun 15, 2019
miss-islington deleted the backport-3a1d50e-3.8 branch June 15, 2019 16:10

miss-islington commented Jun 15, 2019

Copy link
Copy Markdown
Contributor Author

@aixtools and @ncoghlan: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented Jun 15, 2019

Copy link
Copy Markdown
Contributor Author

@aixtools and @ncoghlan: Status check is done, and it's a success ✅ .

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.