← 返回首页
bpo-30535: Explicitly note that sys.meta_path is not empty by Windsooon · Pull Request #13300 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-30535: Explicitly note that sys.meta_path is not empty#13300

Closed
Windsooon wants to merge 1 commit into
python:mainfrom
Windsooon:bpo-30535
Closed

bpo-30535: Explicitly note that sys.meta_path is not empty#13300
Windsooon wants to merge 1 commit into
python:mainfrom
Windsooon:bpo-30535

Conversation

Windsooon commented May 14, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Explicitly note that sys.meta_path is not empty

https://bugs.python.org/issue30535

bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 14, 2019
csabella requested a review from brettcannon May 14, 2019 09:59
jdemeyer requested changes May 16, 2019
View reviewed changes
Comment thread Doc/library/sys.rst Outdated

jdemeyer May 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This is not grammatically correct: a sentence should start with a capital letter and contain a verb.

Windsooon May 16, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thank you, how about
"By default, it holds entries to handle the standard kinds of modules (.py files, extension modules...)."

brettcannon requested changes May 27, 2019
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Technically there aren't different kinds of modules, just different ways of storing code. I have suggested a tweak to the wording.

Comment thread Doc/library/sys.rst
:meth:`~importlib.abc.MetaPathFinder.find_spec` methods called to see if one
of the objects can find the module to be imported. The
of the objects can find the module to be imported. By default, it holds entries
to handle the standard kinds of modules (.py files, extension modules...). The

brettcannon May 27, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment
Suggested change
to handle the standard kinds of modules (.py files, extension modules...). The
that implement Python's default import semantics. The

Windsooon May 28, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

@brettcannon Do you think we should add examples after that. Like:

that implement Python's default import semantics. (BuiltinImporter, FrozenImporter, and PathFinder)

brettcannon Nov 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

No, as that's too easy of a thing to forget to update. Plus there's no guarantee that every interpreter will set up sys.meta_path the same.

bedevere-bot commented May 27, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

csabella requested a review from brettcannon November 20, 2019 01:47
brettcannon requested changes Nov 22, 2019
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I don't think the docs should get too specific as interpreters can choose what to put into sys.meta_path.

csabella commented Jan 26, 2020

Copy link
Copy Markdown
Contributor

@Windsooon, please take a look at the review comments. Thanks!

AlexWaygood commented Apr 19, 2022

Copy link
Copy Markdown
Member

Changes were requested by a core dev over two years ago, but have not been made. I am therefore closing this PR.

@Windsooon, if you're still interested in working on this, feel free to open a new PR. Alternatively, ping me, and I'll happily reopen this PR. Thanks! 🙂

iritkatriel reopened this Jun 21, 2022

iritkatriel commented Jun 21, 2022

Copy link
Copy Markdown
Member

I tried to updated this PR with Brett's comment but I don't think I can. I will create a new PR.

iritkatriel mentioned this pull request Jun 21, 2022
Merged
masklinn mannequin mentioned this pull request Jun 21, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon requested changes
jdemeyer jdemeyer approved these changes

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Footer

© 2026 GitHub, Inc.