← 返回首页
bpo-36817: Fix reference leak for expr_text in f-string = parsing by pablogsal · Pull Request #13249 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-36817: Fix reference leak for expr_text in f-string = parsing#13249

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:refleak_fstring
May 11, 2019
Merged

bpo-36817: Fix reference leak for expr_text in f-string = parsing#13249
pablogsal merged 1 commit into
python:masterfrom
pablogsal:refleak_fstring

Conversation

pablogsal commented May 11, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested review from ericvsmith, ilevkivskyi and larryhastings and removed request for ilevkivskyi May 11, 2019 17:18
pablogsal self-assigned this May 11, 2019

pablogsal commented May 11, 2019

Copy link
Copy Markdown
Member Author

❯ ./python -m test test_future -m test_annotations -R :
Run tests sequentially
0:00:00 load avg: 0.66 [1/1] test_future
beginning 9 repetitions
123456789
.........
test_future passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 324 ms
Tests result: SUCCESS

ilevkivskyi approved these changes May 11, 2019
View reviewed changes

ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks for the fix! LGTM.

ericvsmith approved these changes May 11, 2019
View reviewed changes

ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks for catching this. I kept thinking "I need to remember to make sure that memory gets freed", and then I forgot to do it.

pablogsal commented May 11, 2019

Copy link
Copy Markdown
Member Author

I am restarting the CI because appveyor failed with some random asyncio error.

pablogsal merged commit 5833e94 into python:master May 11, 2019
pablogsal deleted the refleak_fstring branch May 11, 2019 19:54
ericvsmith mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericvsmith ericvsmith approved these changes
ilevkivskyi ilevkivskyi approved these changes
larryhastings Awaiting requested review from larryhastings

Assignees

pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.