← 返回首页
bpo-32424: Deprecate xml.etree.ElementTree.Element.copy() in favor of copy.copy() by GPHemsley · Pull Request #12995 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

bpo-32424: Deprecate xml.etree.ElementTree.Element.copy() in favor of copy.copy()#12995

Merged
scoder merged 1 commit into
python:masterfrom
GPHemsley:bpo-32424-5
Sep 10, 2019
Merged

bpo-32424: Deprecate xml.etree.ElementTree.Element.copy() in favor of copy.copy()#12995
scoder merged 1 commit into
python:masterfrom
GPHemsley:bpo-32424-5

Conversation

GPHemsley commented Apr 28, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue32424

GPHemsley commented Apr 28, 2019

Copy link
Copy Markdown
Contributor Author

@scoder @serhiy-storchaka Does this match expectations?

scoder reviewed Apr 28, 2019
View reviewed changes
Comment thread Lib/test/test_xml_etree.py Show resolved Hide resolved
Comment thread Lib/xml/etree/ElementTree.py
"""
warnings.warn(
"elem.copy() is deprecated. Use copy.copy(elem) instead.",
DeprecationWarning

scoder Apr 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Not sure if we should issue a DeprecationWarning straight away (or a PendingDeprecationWarning first), although I personally wouldn't mind, given that the C implementation has shadowed this method for years (in CPython, that is).
@serhiy-storchaka, what do you think?

GPHemsley May 11, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

FWIW, copy() does not appear in the documentation, either.

GPHemsley May 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Also, I can't find any record of copy ever having been available in the C implementation; it looks like it was __copy__ from the beginning.

The first appearance of copy in the Python implementation was in f15351d (first released in Python 3.1 and 2.7.4), which deemed it "experimental". 84fae78 (first released in Python 3.4) removed that designation when switching from comments to docstrings.

GPHemsley commented Jun 1, 2019

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Any thoughts on this? I think your opinion is the only thing outstanding here.

scoder merged commit 7d952de into python:master Sep 10, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
bpo-32424: Deprecate xml.etree.ElementTree.Element.copy() in favor of… …
eb2eaef
… copy.copy() (pythonGH-12995)
GPHemsley mannequin mentioned this pull request Jun 28, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

scoder scoder left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.