← 返回首页
GH-115869: Make `jit_stencils.h` reproducible by brandtbucher · Pull Request #127166 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

GH-115869: Make jit_stencils.h reproducible#127166

Merged
brandtbucher merged 6 commits into
python:mainfrom
brandtbucher:justin-reproducible
Nov 24, 2024
Merged

GH-115869: Make jit_stencils.h reproducible#127166
brandtbucher merged 6 commits into
python:mainfrom
brandtbucher:justin-reproducible

Conversation

brandtbucher commented Nov 22, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

At the core dev sprint, we discussed the possibility of hosting pre-built jit_stencils.h files for common platforms and build configurations.

While there's a lot of work involved in making that happen (I'll post a rough plan shortly), this is the first logical step in that direction. This PR replaces absolute file paths in the generated code with relative ones, and processes stencils in sorted order.

brandtbucher added build The build process and cross-build 3.14 bugs and security fixes topic-JIT labels Nov 22, 2024
brandtbucher self-assigned this Nov 22, 2024
Comment thread Tools/jit/_stencils.py
offset = len(self.body)
padding = -offset % alignment
self.disassembly.append(f"{offset:x}: {' '.join(['00'] * padding)}")
if padding:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This is an unrelated cleanup.

savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM!

brandtbucher merged commit 17c16ae into python:main Nov 24, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.14 bugs and security fixes build The build process and cross-build topic-JIT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.