← 返回首页
gh-76785: Minor Cleanup of "Cross-interpreter" Code by ericsnowcurrently · Pull Request #126457 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-76785: Minor Cleanup of "Cross-interpreter" Code#126457

Merged
ericsnowcurrently merged 9 commits into
python:mainfrom
ericsnowcurrently:crossinterp-cleanup
Nov 7, 2024
Merged

gh-76785: Minor Cleanup of "Cross-interpreter" Code#126457
ericsnowcurrently merged 9 commits into
python:mainfrom
ericsnowcurrently:crossinterp-cleanup

Conversation

ericsnowcurrently commented Nov 5, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around.

  • *CrossInterpreterData* -> *XIData*
  • crossinterpdatafunc -> xidatafunc
  • split out pycore_crossinterp_data_registry.h
  • add _PyXIData_lookup_t

bedevere-app Bot mentioned this pull request Nov 5, 2024
Closed

ZeroIntensity commented Nov 6, 2024

Copy link
Copy Markdown
Member

It looks like most of this is just find and replace renaming, but I can give it a once-over tomorrow if you want a second set of eyes.

ZeroIntensity approved these changes Nov 6, 2024
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM. There's not much to comment about here--it's all renaming as far as I can tell, and I don't think nitpicking formatting or something like that would be a good use of time :)

ericsnowcurrently merged commit 9357fdc into python:main Nov 7, 2024
ericsnowcurrently deleted the crossinterp-cleanup branch November 7, 2024 16:32
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
pythongh-76785: Minor Cleanup of "Cross-interpreter" Code (pythongh-1… …
64bd446
…26457) The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around. * CrossInterpreterData -> XIData * crossinterpdatafunc -> xidatafunc * split out pycore_crossinterp_data_registry.h * add _PyXIData_lookup_t
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-76785: Minor Cleanup of "Cross-interpreter" Code (pythongh-1… …
63bb816
…26457) The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around. * CrossInterpreterData -> XIData * crossinterpdatafunc -> xidatafunc * split out pycore_crossinterp_data_registry.h * add _PyXIData_lookup_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.